[chirp_devel] [PATCH] [FT8900] Deleted inherited get_bank_model function, fixes #6293
# HG changeset patch # User Kalle Tuulos oh1hqz@gmail.com # Date 1544563646 -7200 # Tue Dec 11 23:27:26 2018 +0200 # Node ID a7e1b67290c9775f5e7be286d2a05855ac4066f2 # Parent 62b4cbefa86738c37317a133f903500f669baf23 [FT8900] Deleted inherited get_bank_model function, fixes #6293
The FT-8900 inherits its class from FT-8800, which defines also the get_bank_model function. The existence of this function is checked in order to decide, whether Banks tab is shown or not. As banks are not supported in FT-8900, the banks tab must not be shown.
diff --git a/chirp/drivers/ft7800.py b/chirp/drivers/ft7800.py --- a/chirp/drivers/ft7800.py +++ b/chirp/drivers/ft7800.py @@ -977,6 +977,8 @@
MODES = ["FM", "NFM", "AM"]
+ del FT8800Radio.get_bank_model + def process_mmap(self): self._memobj = bitwise.parse(MEM_FORMAT_8900, self._mmap)
Hi Kalle,
# HG changeset patch # User Kalle Tuulos oh1hqz@gmail.com # Date 1544563646 -7200 # Tue Dec 11 23:27:26 2018 +0200 # Node ID a7e1b67290c9775f5e7be286d2a05855ac4066f2 # Parent 62b4cbefa86738c37317a133f903500f669baf23 [FT8900] Deleted inherited get_bank_model function, fixes #6293
The FT-8900 inherits its class from FT-8800, which defines also the get_bank_model function. The existence of this function is checked in order to decide, whether Banks tab is shown or not. As banks are not supported in FT-8900, the banks tab must not be shown.
I had applied this, reading your convincing description and quickly looking at the code where we check for the existence of that. I should have looked closer, but the style checker caught it and made me :)
I was able to replicate the issue and verify that just overriding the method in the 8900 class to return None will yield the correct behavior. Let me know if this doesn't work for you and we'll figure out what to do about it.
Thanks!
--Dan
Hi Dan.
Thanks for your fix.
Let me know if this doesn't work for you and we'll figure out what to do about it.
Yes, your correction works fine.
BR, Kalle
pe 14. jouluk. 2018 klo 6.09 Dan Smith via chirp_devel ( chirp_devel@intrepid.danplanet.com) kirjoitti:
Hi Kalle,
# HG changeset patch # User Kalle Tuulos oh1hqz@gmail.com # Date 1544563646 -7200 # Tue Dec 11 23:27:26 2018 +0200 # Node ID a7e1b67290c9775f5e7be286d2a05855ac4066f2 # Parent 62b4cbefa86738c37317a133f903500f669baf23 [FT8900] Deleted inherited get_bank_model function, fixes #6293
The FT-8900 inherits its class from FT-8800, which defines also the get_bank_model function. The existence of this function is checked in order to decide, whether Banks tab is shown or not. As banks are not supported in FT-8900, the banks tab must not be shown.
I had applied this, reading your convincing description and quickly looking at the code where we check for the existence of that. I should have looked closer, but the style checker caught it and made me :)
I was able to replicate the issue and verify that just overriding the method in the 8900 class to return None will yield the correct behavior. Let me know if this doesn't work for you and we'll figure out what to do about it.
Thanks!
--Dan _______________________________________________ chirp_devel mailing list chirp_devel@intrepid.danplanet.com http://intrepid.danplanet.com/mailman/listinfo/chirp_devel Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers
participants (2)
-
Dan Smith -
OH1HQZ Kalle Tuulos