[chirp_devel] [PATCH] Add 'Dual Watch Priority' Setting for UV-5R - Feature #387
This is my first attempt at adding a feature using Mercurial. Is this the result that we are looking for? Jim
This is my first attempt at adding a feature using Mercurial. Is this the result that we are looking for?
Yes, very nice, thanks!
# HG changeset patch # User Jim Unroe rock.unroe@gmail.com # Date 1357049912 18000 # Node ID 5fe99bdf5f0264aece8613882064e54c0890e927 # Parent 7830de9abafdd1b83b04fb107782c94854d7b4de [uv5r] Add 'Dual Watch Priority' Setting Implement a Dual Watch Priority (TDR-AB) setting to compliment the existing Dual Watch (TDR) setting on the Advanced Settings Tab
My one piconit would be to wrap all the lines in the commit message at 78 columns. However, that's minor, so I've applied this to the tree. You can go close the matching bug now.
Thanks very much Jim!
Dan,
OK. NP on wrapping the lines.
Some questions??
Do I have to wait until a patch is committed before I can submit another one? How do I keep the 'chirp' folder up-to-date? Is there some command to update it? Would it be OK to reorganize the Settings tabs for the UV-5R?
Thanks, Jim
On Tue, Jan 1, 2013 at 11:06 AM, Dan Smith dsmith@danplanet.com wrote:
This is my first attempt at adding a feature using Mercurial. Is this the result that we are looking for?
Yes, very nice, thanks!
# HG changeset patch # User Jim Unroe rock.unroe@gmail.com # Date 1357049912 18000 # Node ID 5fe99bdf5f0264aece8613882064e54c0890e927 # Parent 7830de9abafdd1b83b04fb107782c94854d7b4de [uv5r] Add 'Dual Watch Priority' Setting Implement a Dual Watch Priority (TDR-AB) setting to compliment the
existing Dual Watch (TDR) setting on the Advanced Settings Tab
My one piconit would be to wrap all the lines in the commit message at 78 columns. However, that's minor, so I've applied this to the tree. You can go close the matching bug now.
Thanks very much Jim!
-- Dan Smith www.danplanet.com KK7DS
chirp_devel mailing list chirp_devel@intrepid.danplanet.com http://intrepid.danplanet.com/mailman/listinfo/chirp_devel Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers
Do I have to wait until a patch is committed before I can submit another one?
Nope. Are you using the "q" commands (qnew, qpop, qpush, etc)? If so, then you can just create patch on top of patch, on top of patch.
Lets say you have add_tdrtab all set:
% hg qap add_tdrtab
and you want to create another one for "add_foobar" on top of that:
% hg qnew -e add_foobar <edit your commit message>
then make some changes to some files, and qrefresh the patch:
% hg qrefresh
You'll see both applied:
% hg qapplied add_tdrtab add_foobar
Then you can qpush and qpop them on and off the stack if you need to make changes to one or the other of them.
Not sure I explained that properly, but play with it a bit and let me know if you need clarification.
How do I keep the 'chirp' folder up-to-date? Is there some command to update it?
Once something has been committed upstream, you can pop and delete the patch from your tree. Here's an overly verbose example:
% hg qapplied # Show which patches are applied to my tree add_tdrtab # My add_tdrtab patch is applied % hg qpop # "Pop" or unapply the top-most patch % hg qapplied # Now it's no longer applied % hg qunapplied # It's "unapplied" add_tdrtab % hg qdel add_tdrtab # Delete it from my patch queue % hg qunapplied # Now it's gone-gone %
Then you can pull the changes from the upstream repository and update your local tree:
% hg pull -u
At that point, you'll be up-to-date with my tree.
Would it be OK to reorganize the Settings tabs for the UV-5R?
Sure. I think I had some method to my madness originally, but I don't really recall what my plan was. The "Other Settings" was intended to house everything that was in the auxiliary block, which are only settable in the weird way in the VIP software. What did you have in mind?
Would it be OK to reorganize the Settings tabs for the UV-5R?
Sure. I think I had some method to my madness originally, but I don't really recall what my plan was. The "Other Settings" was intended to house everything that was in the auxiliary block, which are only settable in the weird way in the VIP software. What did you have in mind?
I really hadn't thought about it that much yet. Why I asked is because I didn't know what determined if the setting was a Basic and an Advanced setting. I was also worried about what would happen if the list of settings in a tab got too long. Will items in the tab scroll? I also wondered if tabs are added, what would I call them?
Jim
I was also worried about what would happen if the list of settings in a tab got too long. Will items in the tab scroll?
If it doesn't that's a UI bug and I can fix it. If there's a more logical organization of the settings, then I'm fine with changing it up. Probably good to put some thought and discussion to it before making a change just to avoid too much churn for the users so they don't have to hunt for settings each time we move things around :)
Probably good to put some thought and discussion to it before making a change just to avoid too much churn for the users so they don't have to hunt for settings each time we move things around :)
I Agree.
Jim
participants (2)
-
Dan Smith -
Jim Unroe