1 Jan
2015
1 Jan
'15
6:56 p.m.
I accept the criticism as its my first cut and I had troubles.
Definitely don't take offense -- code review is part of open source, and it's a good thing :)
Do I need to do anything about the issue number and line length or will you take care of that? Happy new year.
I'm just observing. Only Dan has commit privileges and he'll want those things fixed before committing.
Yep, my scripts won't even allow it into the tree without a proper commit message that references the issue number with a # sign in front. With mq, it's really easy to amend a patch to make a few changes and resubmit.
Thanks!
--Dan