Oops!
That was a local debug code that slip my inspection into the patch... sorry.
That driver was giving me troubles on windows and I set that code to see what's going on the serial line from inside Chirp; that has not intended to be part of the release code.
Thanks for the advice, don't hesitate to point things that deviate from the Chirp's paradigm in my code, by doing that everyone wins (I learn good practices and the code is more consistent at the end)
I will be more careful on next patches, should I remove this lines via a patch?
73.
El 04/03/16 a las 12:05, Dan Smith via chirp_devel escribió:
- # DEBUG
- #LOG.debug("<== (%d) bytes: %s" % (len(data), util.hexprint(data)))
I'd really rather not have code commented out wherever possible. I think that since this is debug it's probably okay to just leave it on, but if not, can you at least put a flag (or environment check) at the top and gate these on that flag?
--Dan _______________________________________________ chirp_devel mailing list chirp_devel@intrepid.danplanet.com http://intrepid.danplanet.com/mailman/listinfo/chirp_devel Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers