To be honest, no clue if it works or not.... I just noticed it as obviously broken when I started poking at the source, and the change just reverts the part of the patch that broke it several years ago. I certainly would not object if it were removed instead.
Jake On Mon, Nov 26, 2018 at 4:43 PM Dan Smith via chirp_devel chirp_devel@intrepid.danplanet.com wrote:
Hi Jake,
Sorry for the delay in responding to this.
# HG changeset patch # User Jake Merdich jake@merdich.com # Date 1541876657 18000 # Sat Nov 10 14:04:17 2018 -0500 # Node ID 6c90bb305ac2a037008c2132ce836da228619b06 # Parent 88a8f540abef2a884e286f0e7cd9ed39d4ea16cf Fix missing arguments in csvdump script. Fixes #6227.
Does this even work? This was a utility that pre-dated the main chirpw GUI and I'd be shocked to find out that it did anything useful with anything other than maybe a few early radios. Looking at the code (for the first time since 2008) it seems like it literally only supports the four icom radios I started CHIRP with.
Is there any reason to really maintain this in tree? I kinda feel like we should just remove it (indeed I forgot it was even there).
Thoughts from you or anyone?
--Dan _______________________________________________ chirp_devel mailing list chirp_devel@intrepid.danplanet.com http://intrepid.danplanet.com/mailman/listinfo/chirp_devel Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers