Please can somebody reply to me. If only to say we will look at this in a fortnight or whatever?

Thanks

Nicolas

Hi,

https://chirp.danplanet.com/issues/7997#change-28249

* The author is hospitalized at the moment. Hopefully on the mend. I have been helping test it and he asked me to submit it as per his note on the issue page.  

Is this OK? 

If it is I will press on to address the other issues with this driver

Thanks

Nicolas

On Thu, 19 Nov 2020 at 21:04, Nicolas Pike <nicolas@jetblackjelly.com> wrote:

On Thu, 19 Nov 2020 at 20:30, Dan Smith via chirp_devel <chirp_devel@intrepid.danplanet.com> wrote:

> # HG changeset patch
> # User Nicolas Pike <nicolas.jon.pike@gmail.com>
> # Date 1605379022 0
> #      Sat Nov 14 18:37:02 2020 +0000
> # Node ID f0e565a301835f2358ca2842b22e8cfc708c796b
> # Parent  98b8a850b0f136c77fe09a4922c32a2a28f708be
> [senhaix_8800] New Model #7997
>
> diff -r 98b8a850b0f1 -r f0e565a30183 chirp/drivers/senhaix_8800.py
> --- /dev/null Thu Jan 01 00:00:00 1970 +0000
> +++ b/chirp/drivers/senhaix_8800.py   Sat Nov 14 18:37:02 2020 +0000
> @@ -0,0 +1,980 @@
> +# Copyright 2020 Jiauxn Yang <jiaxun.yang@flygoat.com>

Is this someone else's code? Obviously I can't accept someone else's copyrighted code without some indication that they intend it to be redistributed.

https://chirp.danplanet.com/issues/7997#change-28249

* The author is hospitalized at the moment. Hopefully on the mend. I have been helping test it and he asked me to submit it as per the issue page.  

 

> +@directory.register
> +class SenHaiX8800Radio(chirp_common.CloneModeRadio):
> +    """SenHaiX 8800"""
> +    VENDOR = "SenHaiX"
> +    MODEL = "8800"

I just want to check, especially because of the above: is this substantially similar to any other drivers in tree?

* This driver should also work with the Radioddity gs-5b. I do not know how similar this driver may be to any others.

> +    @classmethod
> +    def match_model(cls, filedata, filename):
> +        if len(filedata) in [MEM_SIZE]:
> +            return True
> +
> +        return False

New drivers shouldn't be adding these handlers, you can just rely on the automatic metadata-based matching method from here on out.
* I would need to look into that, as up to this point I have only been testing the driver.

 

Can you please provide a radio image so I can test this?
* Please find attached a radio image.

* Thanks

 

Thanks!

--Dan
_______________________________________________
chirp_devel mailing list
chirp_devel@intrepid.danplanet.com
http://intrepid.danplanet.com/mailman/listinfo/chirp_devel
Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers

_______________________________________________
chirp_devel mailing list
chirp_devel@intrepid.danplanet.com
http://intrepid.danplanet.com/mailman/listinfo/chirp_devel
Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers