Yeah, I’ll take a look.
For clarification, the patch quoted below is the one that added support of settings to all of the FT1900/FT2900 series, and I don’t believe that particular patch is what was causing the problem. I suspect you’re talking about another submission, which added support for a modded version of the FT2900. That was submitted in a similar timeframe, and is here: http://chirp.danplanet.com/projects/chirp/repository/revisions/1c398653986f http://chirp.danplanet.com/projects/chirp/repository/revisions/1c398653986f
I’m now digging through the logic in that test. It’s not obvious to me how adding the support of a modified radio is different from adding support of a European version of the FT-2900/FT-1900 radio, which was done a long time ago (a year or more? I don’t remember, but it was long ago). In both cases, we didn’t add a new .img file to the test cases, there was just a new class added with the same settings overridden.
Anyway, I’ve got to step away from the computer for a while right now, but I just wanted to let you know I’ll be digging into this.
Richard Cochran ag6qr@sonic.net
Sent from my Nye Viking Speed-X
On Apr 1, 2016, at 12:32 PM, Dan Smith dsmith@danplanet.com wrote:
# HG changeset patch # User Richard Cochran ag6qr@sonic.net # Date 1456721059 28800 # Sun Feb 28 20:44:19 2016 -0800 # Node ID 432300d60fae4c517c8f98f3d52aef115c9a96e8 # Parent 1c398653986fb3e0a50bfbbc58f1a2f5c9ab2b95 [FT2900] Add support for settings. Fix #2867 This submission adds support for settings to the ft-2900/ft-1900 driver. Special thanks to Chris Fosnight for getting a start at the settings code. He gave his code to me (Rich Cochran), and I finished implementing more settings, and tested both reading and writing of all the settings. Settings are grouped into categories according to the manual, pp 72-73.
I didn't notice this until now, but this brought the current failure we're seeing. The 2900 and 2900Mod radios are not distinguishable for file detection.
Can you figure out some way to do that so we can get the tests fixed up?
Thanks!
--Dan