Thanks for the suggestions. Will do. Is it better (when feedback like this occurs) for me to send a replacement patch or a patch with just these changes to be laid over the one you reviewed?
Brad Schuler K0BAS
-----Original Message----- From: chirp_devel-bounces@intrepid.danplanet.com chirp_devel-bounces@intrepid.danplanet.com On Behalf Of Dan Smith via chirp_devel Sent: Thursday, November 19, 2020 1:18 PM To: chirp_devel@intrepid.danplanet.com Subject: Re: [chirp_devel] [PATCH] [AnyTone 5888UV] Add limited squelch mode & fix file identifier
@@ -333,7 +336,7 @@ VENDOR = "AnyTone" MODEL = "5888UV" BAUD_RATE = 9600
- _file_ident = "QX588UV"
- _file_ident = "588UVN"
I think this is likely due to you having a different version of the radio from other people, right? This will break their ability to open old images, which we want to try to avoid. Can you alter the detection logic to include both?
# May try to mirror the OEM behavior later _ranges = [@@ -424,6 +427,8 @@ rxtone = txtone = None rxmode = TMODES[_mem.rxtmode]
if _mem.sqlMode == 0 or _mem.sqlMode == 2:
It would be great if you could also use the .index() method below for these two, to increase readability/
rxmode = TMODES.index('') txmode = TMODES[_mem.txtmode] if txmode == "Tone": txtone = TONES[_mem.txtone] @@ -472,6 +477,10 @@ _mem.txtmode = TMODES.index(txmode) _mem.rxtmode = TMODES.index(rxmode)if rxmode != '':_mem.sqlMode = SQL_MODES.index("CTCSS/DCS")else:_mem.sqlMode = SQL_MODES.index("Carrier")
Thanks!
--Dan
_______________________________________________ chirp_devel mailing list chirp_devel@intrepid.danplanet.com http://intrepid.danplanet.com/mailman/listinfo/chirp_devel Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers