So, I understand what you are saying. However, from your description, why bother? The changes I made, except for a couple of changes to calls, were changing "except Exception, e" to "except Exception as e" and "print xxxx" to 'print(xxxx)"

I know the latter one is supported in previous versions of Python (at least with an additional import), but don't know if the "new" exception syntax is supported.

I only have a single radio type (I have two of those), so I cannot test any radio drivers except the one for my radio.

If you think such trivial changes would actually be useful, I can post them somewhere (GitHub comes to mind), but from your description, and the amount of effort that I put into it (very little), I'm not sure the results are worth the time.

I'd be happy to take on additional tasks, but can't find any specific bugs on the py3 branch to work. Just the generic, "port to wxPython."

Is there a test harness that can be used for regression testing? Something that satisfies the requirement to "go beyond syntactical changes..."?

It seems to me that correcting syntactical issues is a prerequisite to making substantive changes to the code base. That, and not having dozens of radios to test upon, severely limits my ability to be helpful.

Joe Pizzi

On Wed, Aug 12, 2020 at 6:33 PM Rudolph Gutzerhagen <rudolph.gutzerhagen@gmail.com> wrote:
Hi Joe,
if you use mercurial you could use that tool to extract a patch file. The instructions are on the chirp site. If you go through them patiently, you will get there.
You could zip up your source tree, mount it somewhere, and post the link here and we can take a look at it.  Alex (next message) did that with a git site. His changes weren't accepted because something was missing, or need for driver testing was a pre-requisite. If I recall correctly, the comment was something about going beyond syntactical changes to satisfy editor/lint etc and making changes to the drivers one at a time ie 0% to 100% each one, none left in various partial complete states. Also, when I looked at the changes, I got confused (easy to do) and gave up choosing the outside, and never came back.
If you make your work visible it's possible to draw from it when the senior devs and reviewers have time. I think including a radio download img file from post patch tests for the radios you test and dont brick would be helpful. Those could be included for addition to the tree.  
If you supply a patch file follow the patch description guideline and tie it to an issue/ticket by number.
Well, a bit of a ramble but hope it helps. I'm new here but that's what I have gathered so far.


On Tue, Aug 11, 2020 at 10:55 PM Joe Pizzi via chirp_devel <chirp_devel@intrepid.danplanet.com> wrote:
I've fixed those errors, but don't know the right way to provide the fixes.

I also don't know if the new syntax is supported in the old version.

I saw another message that indicated somebody else also made the fixes. 

Joe Pizzi 

On Tue, Aug 11, 2020, 9:24 PM Jason Vigil via chirp_devel <chirp_devel@intrepid.danplanet.com> wrote:
Hey folks,


Does anyone have any information regarding the status of Python 3 support? It appears that the `py3` branch has not had any new commits for 6 months now. After following the instructions here: https://chirp.danplanet.com/projects/chirp/wiki/Linux_Python3, I see the following errors (on Ubuntu 20.04):

```
jason@ubuntu-20:~/workspace/chirp.hg$ python3 chirpw
Failed to import /home/jason/workspace/chirp.hg/chirp/drivers/ts480: invalid syntax (ts480.py, line 1141)
Failed to import /home/jason/workspace/chirp.hg/chirp/drivers/kyd: invalid syntax (kyd.py, line 503)
Failed to import /home/jason/workspace/chirp.hg/chirp/drivers/kguv9dplus: invalid syntax (kguv9dplus.py, line 880)
Failed to import /home/jason/workspace/chirp.hg/chirp/drivers/th_uv3r: invalid syntax (wouxun.py, line 277)
Failed to import /home/jason/workspace/chirp.hg/chirp/drivers/ts2000: Missing parentheses in call to 'print'. Did you mean print("Bug: unsupported duplex `%s'" % mem.duplex)? (ts2000.py, line 220)
Failed to import /home/jason/workspace/chirp.hg/chirp/drivers/ft70: invalid syntax (ft70.py, line 1165)
Failed to import /home/jason/workspace/chirp.hg/chirp/drivers/ft450d: invalid syntax (ft450d.py, line 502)
Failed to import /home/jason/workspace/chirp.hg/chirp/drivers/ts590: invalid syntax (ts590.py, line 1647)
Failed to import /home/jason/workspace/chirp.hg/chirp/drivers/anytone_ht: invalid syntax (anytone_ht.py, line 236)
Failed to import /home/jason/workspace/chirp.hg/chirp/drivers/ft1d: invalid syntax (ft1d.py, line 1893)
Failed to import /home/jason/workspace/chirp.hg/chirp/drivers/retevis_rt22: invalid syntax (retevis_rt22.py, line 608)
Failed to import /home/jason/workspace/chirp.hg/chirp/drivers/baofeng_wp970i: invalid syntax (baofeng_common.py, line 167)
Failed to import /home/jason/workspace/chirp.hg/chirp/drivers/baofeng_common: invalid syntax (baofeng_common.py, line 167)
Failed to import /home/jason/workspace/chirp.hg/chirp/drivers/ft2800: invalid syntax (ft2800.py, line 204)
Failed to import /home/jason/workspace/chirp.hg/chirp/drivers/tk760: 'float' object cannot be interpreted as an integer
Failed to import /home/jason/workspace/chirp.hg/chirp/drivers/puxing_px888k: can only concatenate list (not "range") to list
Failed to import /home/jason/workspace/chirp.hg/chirp/drivers/vxa700: invalid syntax (vxa700.py, line 180)
Failed to import /home/jason/workspace/chirp.hg/chirp/drivers/th_uv3r25: invalid syntax (wouxun.py, line 277)
Failed to import /home/jason/workspace/chirp.hg/chirp/drivers/ftm350: invalid syntax (ftm350.py, line 281)
Failed to import /home/jason/workspace/chirp.hg/chirp/drivers/ft2900: invalid syntax (ft2900.py, line 540)
Failed to import /home/jason/workspace/chirp.hg/chirp/drivers/ft60: invalid syntax (ft60.py, line 406)
Failed to import /home/jason/workspace/chirp.hg/chirp/drivers/retevis_rt26: invalid syntax (retevis_rt26.py, line 900)
Failed to import /home/jason/workspace/chirp.hg/chirp/drivers/ft90: invalid syntax (ft90.py, line 335)
Failed to import /home/jason/workspace/chirp.hg/chirp/drivers/radioddity_r2: invalid syntax (radioddity_r2.py, line 614)
Failed to import /home/jason/workspace/chirp.hg/chirp/drivers/retevis_rt23: invalid syntax (retevis_rt23.py, line 849)
Failed to import /home/jason/workspace/chirp.hg/chirp/drivers/vx6: invalid syntax (vx6.py, line 874)
Failed to import /home/jason/workspace/chirp.hg/chirp/drivers/ft7100: invalid syntax (ft7100.py, line 571)
Failed to import /home/jason/workspace/chirp.hg/chirp/drivers/fd268: invalid syntax (fd268.py, line 793)
Failed to import /home/jason/workspace/chirp.hg/chirp/drivers/th7800: invalid syntax (th7800.py, line 539)
Failed to import /home/jason/workspace/chirp.hg/chirp/drivers/mursv1: invalid syntax (baofeng_common.py, line 167)
Failed to import /home/jason/workspace/chirp.hg/chirp/drivers/leixen: invalid syntax (leixen.py, line 264)
Failed to import /home/jason/workspace/chirp.hg/chirp/drivers/tk760g: invalid syntax (tk760g.py, line 910)
Failed to import /home/jason/workspace/chirp.hg/chirp/drivers/kguv8dplus: invalid syntax (kguv8dplus.py, line 421)
Failed to import /home/jason/workspace/chirp.hg/chirp/drivers/ts850: 'dict' object has no attribute 'iteritems'
Failed to import /home/jason/workspace/chirp.hg/chirp/drivers/th9800: invalid syntax (th9800.py, line 601)
Failed to import /home/jason/workspace/chirp.hg/chirp/drivers/baofeng_uv3r: invalid syntax (baofeng_uv3r.py, line 54)
Failed to import /home/jason/workspace/chirp.hg/chirp/drivers/kyd_IP620: invalid syntax (kyd_IP620.py, line 184)
Failed to import /home/jason/workspace/chirp.hg/chirp/drivers/thd72: invalid syntax (thd72.py, line 584)
Failed to import /home/jason/workspace/chirp.hg/chirp/drivers/retevis_rt21: invalid syntax (retevis_rt21.py, line 564)
Failed to import /home/jason/workspace/chirp.hg/chirp/drivers/ft8100: Missing parentheses in call to 'print'. Did you mean print(self.VARIANT, number, tx_freq, mem.freq)? (ft8100.py, line 178)
Failed to import /home/jason/workspace/chirp.hg/chirp/drivers/gmrsuv1: invalid syntax (baofeng_common.py, line 167)
Failed to import /home/jason/workspace/chirp.hg/chirp/drivers/bjuv55: invalid syntax (bjuv55.py, line 650)
Failed to import /home/jason/workspace/chirp.hg/chirp/drivers/thuv1f: invalid syntax (thuv1f.py, line 217)
Failed to import /home/jason/workspace/chirp.hg/chirp/drivers/bj9900: invalid syntax (bj9900.py, line 181)
Failed to import /home/jason/workspace/chirp.hg/chirp/drivers/kguv8d: invalid syntax (kguv8d.py, line 379)
Failed to import /home/jason/workspace/chirp.hg/chirp/drivers/tk270: 'float' object cannot be interpreted as an integer
Failed to import /home/jason/workspace/chirp.hg/chirp/drivers/anytone: invalid syntax (anytone.py, line 180)
Failed to import /home/jason/workspace/chirp.hg/chirp/drivers/th_uv8000: invalid syntax (th_uv8000.py, line 1489)
Failed to import /home/jason/workspace/chirp.hg/chirp/drivers/ft2d: invalid syntax (ft1d.py, line 1893)
Failed to import /home/jason/workspace/chirp.hg/chirp/drivers/alinco: invalid syntax (alinco.py, line 202)
Failed to import /home/jason/workspace/chirp.hg/chirp/drivers/th9000: invalid syntax (th9000.py, line 355)
Failed to import /home/jason/workspace/chirp.hg/chirp/drivers/radtel_t18: invalid syntax (radtel_t18.py, line 481)
Failed to import /home/jason/workspace/chirp.hg/chirp/drivers/uv5x3: invalid syntax (baofeng_common.py, line 167)
Failed to import /home/jason/workspace/chirp.hg/chirp/drivers/ft50: invalid syntax (ft50.py, line 589)
Failed to import /home/jason/workspace/chirp.hg/chirp/drivers/rfinder: invalid syntax (rfinder.py, line 243)
Failed to import /home/jason/workspace/chirp.hg/chirp/drivers/vgc: invalid syntax (vgc.py, line 1413)
Failed to import /home/jason/workspace/chirp.hg/chirp/drivers/ap510: invalid syntax (ap510.py, line 383)
Failed to import /home/jason/workspace/chirp.hg/chirp/drivers/ftm3200d: invalid syntax (ft1d.py, line 1893)
Failed to import /home/jason/workspace/chirp.hg/chirp/drivers/retevis_rt1: invalid syntax (retevis_rt1.py, line 729)
Failed to import /home/jason/workspace/chirp.hg/chirp/drivers/bf-t1: invalid syntax (bf-t1.py, line 228)
Failed to import /home/jason/workspace/chirp.hg/chirp/drivers/lt725uv: invalid syntax (lt725uv.py, line 1396)
Failed to import /home/jason/workspace/chirp.hg/chirp/drivers/tdxone_tdq8a: invalid syntax (tdxone_tdq8a.py, line 304)
Failed to import /home/jason/workspace/chirp.hg/chirp/drivers/wouxun: invalid syntax (wouxun.py, line 277)
Failed to import /home/jason/workspace/chirp.hg/chirp/drivers/uv6r: invalid syntax (baofeng_common.py, line 167)
Failed to import /home/jason/workspace/chirp.hg/chirp/drivers/rh5r_v2: Missing parentheses in call to 'print'. Did you mean print(MEM_FORMAT)? (rh5r_v2.py, line 170)
Failed to import /home/jason/workspace/chirp.hg/chirp/drivers/kguv8e: invalid syntax (kguv8e.py, line 340)
Failed to import /home/jason/workspace/chirp.hg/chirp/drivers/puxing: invalid syntax (puxing.py, line 50)
Traceback (most recent call last):
  File "chirpw", line 139, in <module>
    from chirp.ui import mainapp
  File "/home/jason/workspace/chirp.hg/chirp/ui/mainapp.py", line 1140
    print query
          ^
SyntaxError: Missing parentheses in call to 'print'. Did you mean print(query)?
```


Thanks,
Jason
_______________________________________________
chirp_devel mailing list
chirp_devel@intrepid.danplanet.com
http://intrepid.danplanet.com/mailman/listinfo/chirp_devel
Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers
_______________________________________________
chirp_devel mailing list
chirp_devel@intrepid.danplanet.com
http://intrepid.danplanet.com/mailman/listinfo/chirp_devel
Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers