Re: [chirp_devel] [PATCH] [uv5r] UV-82 use ASCII charset Partially fixes #5227

8 Oct 2017

...
diff -r b4000bed33bd -r c207cd1d97ea chirp/drivers/uv5r.py

--- a/chirp/drivers/uv5r.py	Sat Sep 30 13:10:50 2017 +0200
+++ b/chirp/drivers/uv5r.py	Sat Oct 07 11:58:01 2017 -0400
@@ -764,7 +764,7 @@
        rf.has_tuning_step = False
        rf.can_odd_split = True
        rf.valid_name_length = 7

   rf.valid_characters = UV5R_CHARSET




   rf.valid_characters = getattr(self, '_valid_chars', UV5R_CHARSET)



Indentation is off here. Should be four spaces per indent. Also, can’t you just do self._valid_chars here? Should be the same as your getattr(), even for subclasses.
—Dan

    

Dan Smith