26 Aug
2013
26 Aug
'13
7:34 a.m.
- STEPS = [5, 10, 12.5, 15, 20, 25, 50]
While I understand this works, it's not what the other drivers do. Please make these floats:
STEPS = [5.0, 10.0, ...]
Just for consistency, if you don't mind.
- MODES = ["AM", "FM", "Auto"]
- TMODES = ["", "Tone", "TSQL", "", "DTCS"] # idx 3 (Bell) not ...
- TONES = list(chirp_common.TONES)
- for tone in [ 165.5, 171.3, 177.3 ]:
TONES.remove(tone)
- POWER_LEVELS = ["Hi", "Mid1", "Mid2", "Low"]
- DUPLEX = ["", "-", "+", "split"]
- mem_format = """
Sorry, I didn't notice this before, but I would really prefer that these be module-level and not public class-level variables. Is there some reason you moved these into the class, contrary to the pattern used everywhere else? Class variables with mutable types are pretty dangerous in Python...
I'm not trying to be overly pedantic here, just trying to keep consistency with everything else. You're *really* close; thanks for your work and patience on this :)
--
Dan Smith
www.danplanet.com
KK7DS