- data = radio._mmap[0x0030:]
- data = radio._mmap.get_byte_compatible()[0x0030:]
Not that it matters, but this shouldn't be strictly necessary since you're using MemoryMapBytes right?
This is necessary because the driver is still given the old MemoryMap when the user loads the image from a file, and will break uploading on Python 3. Ideally, the directory module should initialize the driver with MemoryMapBytes based on a class attribute.
On another note, MemoryMapBytes returns str on Python 2, and we should probably make it return python-future bytes. Many breakages may occur so this should be tested thoroughly.
def do_download(radio): do_ident(radio)
- data = "TH350 Radio Program data v1.08\x00\x00"
- data += ("\x00" * 16)
- data = b"TRI350 Radio Program data v1.08\x00"
- data += (b"\x00" * 16)
Why did you change this and the match_model stuff? In the past, we definitely couldn't do something like this because it would make images created by newer chirp incompatible with older chirp for no real reason. Since your driver only existed after the metadata change, this doesn't really affect you, but I don't really want to get into the habit of doing this without good reason.
This is the header that the official Windows programmer uses, and the change will allow CHIRP images to be read by the official app (and vice versa). I really should have noticed this earlier when I first submitted the driver.
Thanks, Zhaofeng Li