Almost done adding support for Radioddity FS-T3. Currently all tests pass for the files I touched, except for a few like this: XFAIL tests/test_drivers.py::TestBitwiseStrict_Radioddity_FS-T3::test_bitwise_unnecessary_seek
After commenting out "#seekto 0x0000" the Retevis RB18 driver that I'm using as a superclass passes, but it still complains about mine. At run time it says "Unnecessary #seekto 0x0630" when downloading as FS-T3 but not as RB18.
Apparently it's because they have the same memory size but different channel ranges. With fewer than 99 channels (RB18 = 22ch) it needs the #seekto to find the settings. With 99 channels the end of channel memory meets the start of settings, making the #seekto unnecessary. Setting channels to 98 silences the warning. Commenting out the 0x0630 line in the memory map causes an index out of range error for RB18.
Is there a preferred way to handle this conflict? Officially the FS-T3 is marketed as a 22 channel radio, but Radioddity's own software allows 99 channels by default. It's a nice feature for keeping 1-22 pristine while leaving room for group channels.
Does anyone have a Baofeng BF-T12 for testing? It looks very similar and Baofeng's official software (also 99 channels) works with my FS-T3. I've already heard from someone who has a Radioddity PR-T3. For user convenience I added lightweight subclasses for these models.
---- Charles Terrell tachyon@pobox.com