Dan
I am working in Windows which has no native diff program, I had to use "Exam Diff" and used the unix style output from it, which is why it is not your expected format.
I had a very quick look at your code, and wanted a quick and easy implementation for myself to use; certainly mods to the ID880 could make it work in a nicer programmatic manner. When I get the time I will try your diff.
I am sure there are lots of ic80ad owners that would appreciate their radio being supported.
Andrew Hart C.Eng. MRINA
amateur radio calls G8VTV / VE3NVK locator FN25bh
28, Chimo Drive, Kanata, ON, K2L 1A5 Canada
tel: 613 592 5043
The content of this message is NOT intended for the public, and is a private communication.
On 25 April 2011 21:01, Dan Smith
<dsmith@danplanet.com> wrote:
> Below are three unix style diffs for the files mainapp.py, directory.py
> and convert_ICF.py
Typically patches are submitted in "unified format", which is generated
by running "diff -u <orig> <new>". This makes them much easier to read
and apply.
> < class IC80ADRadio(icf.IcomCloneModeRadio, chirp_common.IcomDstarSupport):
> ---
> > class ID880Radio(icf.IcomCloneModeRadio, chirp_common.IcomDstarSupport):
I think I've already got a suitable class (and model ID) at the bottom
of id880.py, don't I? Looks like I never added it to the directory,
which would explain why it doesn't work yet.
I think that the following diff should suffice, right?
diff -r 2abd55d12a72 chirp/directory.py
--- a/chirp/directory.py Mon Apr 25 16:27:03 2011 -0700
+++ b/chirp/directory.py Mon Apr 25 17:58:51 2011 -0700
@@ -36,6 +36,7 @@
"ic9x:B" : ic9x.IC9xRadioB,
"id800" : id800.ID800v2Radio,
"id880" : id880.ID880Radio,
+ "id80" : id880.ID80Radio,
"icx8x" : icx8x.ICx8xRadio,
"idrpx000v" : idrp.IDRPx000V,
"icq7" : icq7.ICQ7Radio,
> Further, when downloading or uploading back into the radio the data rate
> remains at 9600 and does not speed up as it appears it should, and as
> does happen with the Icom programme. This means that the data transfer
> takes several minutes with Chirp. Perhaps I missed something in the
> code, as I did not take a great deal of time looking.
Nope, I don't have the speed change implemented for anything other than
the IC91/92AD (as it's required because they can be in either mode
without notice).
If the above diff works for you, I'll add it to the tree and we can
claim ID80 support. Thanks!
--
Dan Smith
www.danplanet.com
KK7DS
_______________________________________________
chirp_devel mailing list
chirp_devel@intrepid.danplanet.com
http://intrepid.danplanet.com/mailman/listinfo/chirp_devel