Thanks for looking at it Tom, I accept the criticism as its my first cut and I had troubles. Do I need to do anything about the issue number and line length or will you take care of that? Happy new year.
James
On Dec 31, 2014, at 6:50 PM, Tom Hayward tom@tomh.us wrote:
2014-12-31 15:25 GMT-08:00 jml jml@jmlzone.com:
I know this is a small detail, but you need # in front of the issue number for it to be detected correctly.
You have some lines greater than 79 characters. These should be wrapped. https://www.python.org/dev/peps/pep-0008/#maximum-line-length
The patch is really funky and hard to read--it intermingles _upload() and old set_memory(). I'll have to import this before I can comment on much more.
Glad to see someone picking up support for this radio. There seems to be a lot of demand.
Tom KD7LXL _______________________________________________ chirp_devel mailing list chirp_devel@intrepid.danplanet.com http://intrepid.danplanet.com/mailman/listinfo/chirp_devel Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers