Re: [chirp_devel] [PATCH] [uv-b5] Add 'off' to the list of Duplex options

4 May 2013


      On Sat, May 4, 2013 at 4:55 PM, Dan Smith dsmith@danplanet.com wrote:
...
...
@@ -290,6 +294,10 @@
             _mem.set_raw("\xFF" * 16)
             return

   if mem.duplex == "off":


       mem.offset = mem.freq


       mem.duplex = "-"




This modifies the object that was being passed in, which is "bad". It
won't technically hurt anything when using the GUI, but it could have
other ramifications if the driver is used for something else.
Instead, can you just handle this near where the _mem object is
changed, like this:
if mem.duplex == "off":
    _mem.duplex = DUPLEX.index("-")
    _mem.offset = _mem.freq
else:
    _mem.offset = mem.offset / 10
    _mem.duplex = DUPLEX.index(mem.duplex)


Dan,
Yes. I'll take care of it. Thanks
Jim

    

Jim Unroe