I'm a python newbie, working in a weird environment (Gentoo Linux). I could not run ./runtest in either my Pythom 2 repository (tip) or in my py3 branch repository. When I forced it on my python 2 repository by modifying the bash script to run python2, the test passed. Hmm. I'll wait for your patch.
On Sat, Feb 16, 2019 at 12:43 PM Dan Smith via chirp_devel < chirp_devel@intrepid.danplanet.com> wrote:
The code looks only at ctone in that case because that's the way I
(perhaps incorrectly) interpreted the description at :
https://chirp.danplanet.com/projects/chirp/wiki/DevelopersToneModesI'll fix it. How do you run the test manually?
The command is the first line of the quoted failures from my last mail, but basically:
$ cd tests $ ./run_tests -d Yaesu_FT-4XR
The version(?) string I get back is b'IFT-35R\x00\x00V100\x00\x00\0x06' This looks like it's generic for all radios that use the Yaseu ICU-35
cable, and that it has provisions for versioning.
Hmm, well, I'd tend to do something with that. How about just making sure it starts with IFT-35R and if so, plow ahead?
There is also information in the radio's memory block 0. This looks like
(perhaps) a radio software version.
If I fail out, it is possible to let the user decide to continue?
No, but it's usually good to be conservative here. I would say log information about what you got and what you were expecting and then raise RadioError saying that the model appears incompatible. Then if someone files a bug about having a FT-4XR that should work but doesn't, we can go from there.
I meant to say in the last email: Thanks a lot for caring about making it work on python3 as well :)
I figured out the issue in the test runner and will get that pushed up soonish.
Thanks!
--Dan
chirp_devel mailing list chirp_devel@intrepid.danplanet.com http://intrepid.danplanet.com/mailman/listinfo/chirp_devel Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers