[chirp_devel] [PATCH] [UV-5001] "VFO/MR Switching" setting logic is reversed

10 Sep 2016

# HG changeset patch
# User Jim Unroe rock.unroe@gmail.com
# Date 1473521641 14400
# Node ID a1b8b53606f6025fc1ad727331837cfc7759f178
# Parent  aca37afa55e8515c6880b6bf8ebb76e1eab4b079
[UV-5001] "VFO/MR Switching" setting logic is reversed
The "VFO/MR Switching" setting for both the BTECH UV-5001 and UV-2501
has the logic inverted. This patch corrects this logic.
Bug #4009
diff -r aca37afa55e8 -r a1b8b53606f6 chirp/drivers/btech.py

--- a/chirp/drivers/btech.py	Thu Sep 08 20:57:54 2016 -0700
+++ b/chirp/drivers/btech.py	Sat Sep 10 11:34:01 2016 -0400
@@ -1284,7 +1284,7 @@
         if self.MODEL in ("UV-2501", "UV-5001"):
             vfomren = RadioSetting("settings2.vfomren", "VFO/MR switching",
                                    RadioSettingValueBoolean(
-                                       not _mem.settings2.vfomren))
+                                       _mem.settings2.vfomren))
             advanced.append(vfomren)
reseten = RadioSetting("settings2.reseten", "RESET",
@@ -1569,8 +1569,6 @@
                     if element.has_apply_callback():
                         LOG.debug("Using apply callback")
                         element.run_apply_callback()
-                    elif setting == "vfomren":
-                        setattr(obj, setting, not int(element.value))
                     elif element.value.get_mutable():
                         LOG.debug("Setting %s = %s" % (setting, element.value))
                         setattr(obj, setting, element.value)

    