Re: [chirp_devel] Info Prompt

21 Jun 2018


      ...
OK, found the problem was with EOL chars; marked all lines as changed. So here are the patch files for the new Information Prompt and the two drivers effected so far....
That wasn't why I hadn't looked at it (sorry about that), but... cool :)
...
# HG changeset patch
# User Rick DeWitt aa0rd@yahoo.com
# Date 1529599413 25200
#      Thu Jun 21 09:43:33 2018 -0700
# Node ID a232e3e57d23ad5d67f14ea8ac4b145658a7a628
# Parent  8b1b394fd9a66633e5bacd480affdcd501dc7dad
[mainapp] Add Information prompt per #5889
Adds new config boolean, new help tab toggle and show_information method.
(snip)
...
@@ -635,12 +666,13 @@
     d = gtk.MessageDialog(parent=self, buttons=gtk.BUTTONS_OK)
     d.set_markup("<big><b>" + _("{name} Instructions").format(


                name=radio.get_name()) + "</b></big>")




            name=radio.get_name()) + "</b></big>")
   msg = _("{instructions}").format(instructions=message)


   _again_msg = "Don't show instructions for any radio again"


   d.format_secondary_markup(msg)





   again = gtk.CheckButton(


       _("Don't show instructions for any radio again"))




   again = gtk.CheckButton(_(_again_msg))
   again.show()
   again.connect("toggled", lambda action:
                 self.clonemenu.set_active(not action.get_active()))



I think these changes are unrelated to your patch, and I think the change you made to the translation marking (the _() bit) will break that functionality.
...
@@ -669,6 +701,9 @@
             # User does not want to proceed with experimental driver
             return

   if rclass.get_prompts().display_info is True:



You don't need to add the display_info boolean to the prompts object. Just use the fact that it's set at all to determine whether or not to show it like the other prompts.
...

       self._show_information(rclass, rclass.get_prompts().info)




Hmm, so I had thought you were intending to show this at some different time. Like, not at pre-clone time. Otherwise this becomes just a double-hit when they go to do every download.
Wouldn't this information be useful when they open an image they've already saved? And, in that same line of thinking, wouldn't it be more useful _after_ they do the download, before they start mucking with the memories?
So I'm thinking the ways you hit this would be:
Clone download -> (get instructions) -> cloning -> resulting image opens -> Info prompt shown
and
Open existing image -> Info prompt shown
What do you think?
Otherwise looks pretty sane I think. Thanks!
--Dan

    

Re: [chirp_devel] Info Prompt

Dan Smith