🐖📻📡 (joke aside, since this is printable it's not the best option)
Yup, changed.
Had to sleep on it, but I remembered a use case. We can currently save-as .vx5, allowing .img edited by Chirp to be opened with VX5 Commander. VX5 Commander also uses the simple flash-dump image format, but with a .vx5 extension. Will this still be possible? Looks like the driver could override save_mmap() to restore the original functionality.
The only driver I know of that overrides it currently is the csv one, which works fine.
I tried the .vx5 save and sure enough it adds the metadata to it. I don't remember how that plumbing works, so I'll go resolve that before I commit this.
I've started work on a number of Chirp drivers that don't implement upload/download, but just read a binary file from disk (downloaded with first-party software), modify it, and expect the first-party software to be able to open and upload it back to the radio.
Yeah, so overriding save_mmap() for those cases will work as it does for the CSV driver. As long as the directory is graceful about no metadata and lets the driver's match method have a go at it, we should be fine for drivers like you describe.
--Dan