On Wed, Jul 3, 2013 at 7:48 PM, Dan Smith dsmith@danplanet.com wrote:
Hi Jim,
Thanks for working on this, and sorry for the delay in responding.
Sorry it took me so long to get my head around this. I thought some more about your guidance and suddenly woke up the other morning with a sense of knowing what I needed to do (I think).
def _do_upload(radio):
- _ident_radio(radio)
- ident = _ident_radio(radio)
- # VHF/UHF = "\x04" or "\x42" (original)
- # VHF/220 = "\x02"
Can you actually set these as constants at the top of the file, like STEPS, STEP_LIST, etc?
Actually, these were just comments to show what I was looking for. So they are gone now. I really only need the one for VHF/220 so I made ...
vhf_220_radio = "\x02"
and put it just above STEPS
- radio_upper_band = ident[3:4]
- image_upper_band = _upper_band_from_image(radio)
- if image_upper_band == "\x02" or radio_upper_band == "\x02":
Then you can use those here instead of the raw hex, for more clarity.
Done. There was one down near 'rf.valid_bands' too.
if image_upper_band != radio_upper_band:raise errors.RadioError("Image not supportted by radio")"supported" is misspelled.
Yeah. My tester caught that and I resubmitted a corrected patch earlier this morning.
Thanks!
-- Dan Smith www.danplanet.com KK7DS
Jim KC9HI