On Wed, Jul 10, 2013 at 7:50 PM, Dan Smith <dsmith@danplanet.com> wrote:

> + u8 rogerrx;
> } settings[2];

We need to remove the legacy use of settings as an array. This is an
artifact of a previous bug in bitwise which has since been fixed. Not
your fault, but by knee-jerk reaction was that this addition would
break the array :)

I've always wondered why it was like this. But I try to leave things alone that I don't need to change because I don't want to break things.

> -TDRAB_LIST = ["Off", "A", "B"]
> +TDRAB_LIST = ROGERRX_LIST = ["Off", "A", "B"]

This is a little confusing, I think we could just use the same list for
both functions. But, I can't find anything else to complain about, so I
won't ask you to change it.

I originally tested it out using the same list for both functions. I didn't do it that way because I thought a "TDR" list being used for a "ROGER" function would be confusing. I supposed the list could have been renamed to something more generic.

Thanks! :)

Thank you for your help with getting us started. It's kind of neat adding a new radio without ever having touched one.

Jim