This driver is very similar to the TH9800 driver. The memory map is slightly different, the features differ a bit, and the upload/download sequence is slightly different.
Okay, generally we would make those a single driver base class with subclasses for the variants. If you don't have the radio to test with them we'll just have to keep them separate for now I guess.
Hmm, why is this copied into the driver?
add_radio_setting(basic, "apo", "Auto Power off (Hours)",[("Off", 0), ("0.5", 5), ("1.0", 10), ("1.5", 15), ("2.0", 20)],_settings.apo)I'm sorry, I don't understand your question. FWIW, APO is a feature that was broken in the TH9800 and I've fixed it in the TH7800. I planned to show the TH7800 authors how I've fixed it.
This referred to the bit above, which is the common code.
There are probably a few things we could discuss about the driver. I almost forgot about the comments I added about "common code" that could potentially be moved to a different module for all to use. You're probably the right person to talk to about that.
Yep, please just put those pieces in settings.py next to the others.
I can run the pep8 tester - hadn't done that. I'm sure I can break the lines before 80 columns.
Cool, thanks. I'll probably complain about a few other bits.
The tests pass with the driver.
Excellent. If you can fix up the style bits and move the common stuff over to the right place we should be good to go.
Thanks!
--Dan