Dan,

Jim sent an image…

It does look a bit like the ICOM protocol (I started there) – but uses its own subcommand just for doing a memory dump and upload.  So unfortunately no overlap.

I hope that it will work with other TYT radios though because the programmer seems to be written with multiple radios in mind (I decompiled it to get some of the checksum info calculation and memory layout).

Jim did the topping and tailing (I don’t have a lot of time for testing now), the timeout as is was as it was in the driver that I cribbed from – I’m sure it could be almost anything.

Best wishes

James

From: chirp_devel-bounces@intrepid.danplanet.com <chirp_devel-bounces@intrepid.danplanet.com>
Date: Thursday, 19 November 2020 at 20:58
To: chirp_devel@intrepid.danplanet.com <chirp_devel@intrepid.danplanet.com>
Subject: Re: [chirp_devel] [PATCH] [TH-UV88] New Model: TYT TH-UV88 (replacement for previous patch)

> # HG changeset patch
> # User Jim Unroe <rock.unroe@gmail.com>
> # Date 1605729943 18000
> #      Wed Nov 18 15:05:43 2020 -0500
> # Node ID 9379757e3946f6da034d96093ad188c9b93dd622
> # Parent  d5e496f563fdfc9ea89dea5f119357235b82db6f
> [TH-UV88] New Model: TYT TH-UV88 (replacement for previous patch)
>
> This patch adds support for the TYT TH-UV88
>
> Initial radio protocol decode, channels and memory layout
> by James Berry <james@coppermoth.com>, Summer 2020
>
> Related to #7817

Can we get an image for testing this?

> +def _clean_buffer(radio):
> +    radio.pipe.timeout = 0.005

This is 5ms, too low to be meaningful on most systems I think, and it looks like this is just for the serial purge. I think something like 100ms is a lot better. I'm not sure how long it takes to read 256 bytes at 57600 but it wouldn't surprise me if this is too short to even clear most buffers.
>
> +def _make_read_frame(addr, length):
> +    frame = "\xFE\xFE\xEE\xEF\xEB"

This isn't going to be py3 compatible, but I'm so behind on processing this stuff I guess maybe I shouldn't be too picky.

> +    """Pack the info in the header format"""
> +    frame += struct.pack(">ih", addr, length)
> +
> +    frame += "\xFD"
> +    # Return the data
> +    return frame

Also, this does look a *lot* like the icon protocol. Have you tried seeing if the icom radio base will talk to this?

--Dan
_______________________________________________
chirp_devel mailing list
chirp_devel@intrepid.danplanet.com
http://intrepid.danplanet.com/mailman/listinfo/chirp_devel
Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers