Hi,
On Sat, May 4, 2013 at 12:12 PM, Dan Smith dsmith@danplanet.com wrote:
I don't know if you like large patches or small patches, so I favoured a smaller self contained patch that didn't add any functionality. I'm half way there on populating the settings menu, so if you prefer you can wait a few days and receive a patch that has the memory layout and the settings menu code. Your call.
I prefer small, I was just confused by the subject :)
The attached patch adds menus to Chirp for the APRS settings in the VX-8[DG][RE] series radios. I don't have a VX-8D to test against and I can see that it has a different memory layout so the menu is not enabled for that model. This patch should add all of the options available in the APRS menu for the supported radios.
There is a memory image from me VX-8DR attached to bug 821 that you can use for testing.
The patch from earlier in this thread is no longer needed, it's included in this patch.
The VX-8 directly uses some enumerated values from the APRS standards. I've added these to chirp_common as they may appear in other radios. They are unmodified, in that the indexes of the items match the indexes from the standards. Other constants that are local to these radios are included in vx8.py.
The latitude/longitude conversion code might do well in chirp_common, but it's in vx8.py for now. Latitude/longitude conversion is included so that they can be displayed in the users preferred format and the user can enter them in either accepted format.
I would have liked to have altered some displayed fields based on the users actions in real time, for example changing the latitude/longitude display format when the user changes their lat/long display format preference.
Robert Terzi put me in contact with Geoffrey Merck (F4FXL), who contributed testing, suggestions and some memory locations to this patch. He also tested it against the VX8-GE, which is newly supported in Chirp with this patch.