3 Dec
2013
3 Dec
'13
6:05 a.m.
On Mon, Dec 2, 2013 at 1:47 PM, Dan Smith dsmith@danplanet.com wrote:
This set adds two things:
- A strict(er) set of style checks for a given patch. This will enforce
<80 column lines for all files touched in a patch. This will avoid failing on everything right now, but any patch that touches a file will need to fix all the lines. This is a nice ideal, but I'm not sure how other folks feel about it. This check also verifies the bug number in the commit message, etc. I'd like this to be a "does this meet style requirements" hook for people to run before submitting a patch.
- A top-level test function that runs everything we have, to maybe help
avoid what happened recently, where the unit tests passed, but the driver tests did not.
If folks like this, I'll make jenkins run all of this on each build.
This makes sense to me, I don't see a problem with using it.
mike