Ok, I fixed the issue that was causing the unit test failures, and added the correct modes (tone, dtcs, cross, etc). I ran the unit tests on two radio images, and they all passed. I also tested the patch with a radio and confirmed operation.
Review this patch again for inclusion in the chrip base.
I've included the test images that I used in the ticket (#1035), so you can include them in the test image corpus if you so chose.
thanks,
Dave kk6df
On Sat, May 2, 2015 at 1:14 PM, Dan Smith dsmith@danplanet.com wrote:
# HG changeset patch # User David Fannin dfannin@sushisoft.com # Date 1430596915 25200 # Sat May 02 13:01:55 2015 -0700 # Node ID 9e5169ff126fe5bc82ce076e487898c91fd2c7b8 # Parent 31a7494c324a347634c30cc3c9bded2ce83eeb21 [Th9000] New model driver for TYT TH9000D radios - fixed base class
#1035
Hi Dave, thanks for the respin. I was just going to apply this and when I ran it with the test image on the bug, I get this:
dan@eagle:~/dev/chirp/tests$ ./run_tests -d TYT_TH9000_144 TYT TH9000_144 Detect PASSED: All tests TYT TH9000_144 Settings PASSED: All tests TYT TH9000_144 Clone PASSED: All tests TYT TH9000_144 Edges PASSED: All tests TYT TH9000_144 BruteForce FAILED: Field `tmode' is `',
expected `TSQL-R'
TYT TH9000_144 CopyAll PASSED: All tests TYT TH9000_144 Banks SKIPPED: Banks not supported
Results: TOTAL : 7 FAILED : 1 SKIPPED: 1 PASSED : 5 CRASHED: 0
If I apply this with that failure, the build system won't be happy. Can you make sure that all the tests run for this driver before we apply it? Thanks!
--Dan
chirp_devel mailing list chirp_devel@intrepid.danplanet.com http://intrepid.danplanet.com/mailman/listinfo/chirp_devel Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers