Thank Dan! It was my first time touching python and my first time working with a desktop Gui at all so I appreciate your time in cleaning it up. I can work on a progress bar, but I though since the USA version didn't have one, neither should the Canada one. I suppose I could do one for both! I'll diff your version to learn about what I missed! Cheers, -MarkSent with dubious spelling from my pocket sized supercomputer ------ Original message------From: Dan Smith via chirp_develDate: Sun., Dec. 20, 2020 11:27To: chirp-devel;Cc: Subject:Re: [chirp_devel] Add Search for RadioReference for Canada fixes #8021Sorry for the delay, I finally got around to being able to test this.
Sorry, didn't realize it was meant to go by email as well. Here's the patch (attached). Fixes #8021
This seems to work for me, although I think you probably want some sort of progress dialog in between the login box and the province selection, because it's not clear why there's a big delay and that you're waiting for that to come back.
Also there were quite a bunch of style test failures. Since I delayed looking at this so long, I fixed these up for you this time, but in the future, please run (and pass) the style checks first.
Thanks!
--Dan _______________________________________________ chirp_devel mailing list chirp_devel@intrepid.danplanet.com http://intrepid.danplanet.com/mailman/listinfo/chirp_devel Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers