Thanks!
Looks good and everything is working as it should then. I'm surprised I never noticed the duplicate none entry before.
-----Original Message----- From: "Tom Hayward via chirp_devel" chirp_devel@intrepid.danplanet.com Sent: 10/7/2015 9:24 AM To: "chirp_devel@intrepid.danplanet.com" chirp_devel@intrepid.danplanet.com Subject: Re: [chirp_devel] [PATCH 2 of 2] drivers/ft60: add support for"off"duplex mode (#2891)
On Tue, Oct 6, 2015 at 10:23 PM, Patrick Lang via chirp_devel chirp_devel@intrepid.danplanet.com wrote:
For CHIRP in general - does “off” mean:
a) duplex / repeater shift is disabled and the radio should operate in simplex mode
or
b) Tx is inhibited
It's, of course, "b": http://chirp.danplanet.com/projects/chirp/wiki/MemoryEditorColumns#Duplex
For issue 2891 – I think it would be cleaner to simply remove the extra “” from line 275, rather than stripping it from the array as its assigned to the rf object in line 367. Is the extra “”, “” needed in line 275 to effectively 1-index the duplex value instead? If not, it seems like we could just strip it out and assign the array as-is. This is how the VX-6 and most other drivers work.
Yes, the array index is important here.
Tom KD7LXL _______________________________________________ chirp_devel mailing list chirp_devel@intrepid.danplanet.com http://intrepid.danplanet.com/mailman/listinfo/chirp_devel Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers