- Developers - lists.chirpmyradio.com

Re: [chirp_devel] FT1D and UI... seems to be OK, now. A bit of help still desired.
by Declan Rieb 07 Jun '23

07 Jun '23

> On Jun 7, 2023, at 13:00, chirp_devel-request(a)intrepid.danplanet.com wrote: Thanks for the very prompt attention. I’m trying to add features to the ft2d.py (and ft3d.py) but they’re almost all handled in the ft1d.py, which radio has the same features (along with several other Yaesu radios.) And you’ve described a “feature” of my driver that I am vaguely aware of. In the radio, they are indeed in adjacent slots! So, I looks as if I’ve fixed it by making the number field negative for specials (as I’ve seen in others’ implementations. Doh!) Yay, so far. Tox was still happy with the new driver. (Unless you’re VERY fast, I’ve not done a git pull since this morning.) You pointed me in the right direction. It’s still a bit strange that it only shows up in the UI, but I understand that I confused it. I think it’ll be a wonderful idea to add a tax test to check for my (previous?!) bad implementation. > I haven't debugged your problem, but the reason for the UI disconnect is that you;'re returning an overlapping set of special memories with the regular ones. You need to map your special memories somewhere that does not overlap with the regular numbered memories (i.e. start right after the last regular memory). So when you edit memory 1, you'll notice that "Home2" actually changes waaay down at the bottom of the memory editor. During the initial load, you've returned a special memory with a number=1 and so chirp thinks that's where memory number 1 goes. > > I'll take a todo to write a test to cover this if we really don't already h one. Yes, I’ve made many changes, serially, and only locally. I’ll happily work on the big GitHub. I can also try to separate them, and build a branch on your real master onto GitHub. But: (A big but:) I’ve never used git in a collaborative environment, and am afraid of messing up the big github somehow. I’ve only entered one “issue” in your CHIRP documentation (#6151, asking to add digital settings) and some of my changes attend to that. There is a logic error that prevents CHIRP from initializing settings on a default Yaesu ADMS-x file; I’ve not entered a bug report for it, but it was an easy fix. Adding the specials was a labor of love, since the FT4 driver does it fine. I’ve noticed that #7561 exists, and since I’m aware that the .dat files are essentially the same as the .ftXd files (I think ten bytes’ difference in header) that I can try to fix that one too (that’d be a boon since these radios can save memory to an Scared, using the .dat file format, so folks could handle the radio without having to buy the [ahem: very expensive] Yaesu programming cable, bypassing a lot of headaches for you, I think!) I’ve not started on that. Yaesu has more than 100 preset frequencies for use only on receive (WX channels, maritime VHF, SW broadcast.) Several of their radios have these defined and can be accessed by the VFO AND be referenced in banks. (that’s the root cause of #5167, which is now closed; CHIRP ignores the problem.) I’d like to fix that to actually handle these channels; they’re not in programmable memory, and can really only be accessed via the bank system. Perhaps they can just be specials with really big negative indices (but they do not reside in memory and are all immutable) Is it still necessary to refer to issue numbers, especially in this age of CHIRP_next? I suppose I can add bug and feature requests to cover my efforts. So a little handholding will help me: What’s a PR? I presume that I should make a branch, put in one set of changes, then make another branch based on the first one to add another set of changes, then make another branch based on the second one to add another set of changes, continuing until everything is done. Then some how I communicate to you which change sets are available? Or does one make multiple branches each from the master, each of which changes a smallish set of things? How does one integrate the whole mess, especially with collisions likely? I also believe that FTM3200 radio, which inherits from the FT1D, should not be presently working. (the _mem_params arguments are in the wrong places to work right now. Should I worry about that at all? I tried to contact the driver folk listed in FTM3200.py via email, with no answer, but perhaps it’s not really used and so is moot? >> A copy of my modified ft1d.py:<ft1d.py> > > In the future, a draft github PR (or at least a diff) would be a lot easier to look at and pull down to try. However, you've got a ton of change in your .py file from current master, which makes it really hard to tell what all you've changed. Please do split that up into pieces before you submit, otherwise it'll be really difficult to review. > > --Dan

2 1

[chirp_devel] Is it ok to remove SETTING_LISTS from all drivers?
by Daniele Forsi 05 Jun '23

05 Jun '23

Hello, The flake8 tool detects duplicate keys in the SETTING_LISTS dictionary in some drivers, however those drivers don't use that dictionary and use the different values by checking the model of the radio. That dictionary doesn't seem to be used by any driver. The tests still pass after removing it. Is it ok to remove SETTING_LISTS from all drivers? This is the list of duplicate dictionary keys: ./chirp/drivers/retevis_rt21.py:562:5: F601 dictionary key 'cdcss' repeated with different values ./chirp/drivers/retevis_rt21.py:563:5: F601 dictionary key 'cdcss' repeated with different values ./chirp/drivers/retevis_rt21.py:578:5: F601 dictionary key 'voice' repeated with different values ./chirp/drivers/retevis_rt21.py:579:5: F601 dictionary key 'voice' repeated with different values ./chirp/drivers/retevis_rt21.py:580:5: F601 dictionary key 'voice' repeated with different values ./chirp/drivers/radtel_t18.py:195:5: F601 dictionary key 'sidekey2' repeated with different values ./chirp/drivers/radtel_t18.py:196:5: F601 dictionary key 'sidekey2' repeated with different values ./chirp/drivers/radtel_t18.py:197:5: F601 dictionary key 'sidekey2' repeated with different values ./chirp/drivers/radtel_t18.py:198:5: F601 dictionary key 'sidekey2' repeated with different values ./chirp/drivers/radtel_t18.py:200:5: F601 dictionary key 'sidekey2S' repeated with different values ./chirp/drivers/radtel_t18.py:201:5: F601 dictionary key 'sidekey2S' repeated with different values ./chirp/drivers/bf_t8.py:123:5: F601 dictionary key 'tot' repeated with different values ./chirp/drivers/bf_t8.py:124:5: F601 dictionary key 'tot' repeated with different values -- 73 de IU5HKX Daniele

1 0

[chirp_devel] bitwise struct syntax error
by Craig Jones 02 Jun '23

02 Jun '23

I'm trying to define a block of memory that contains 5 pairs of VFO scan limits (low-high ranges). The storage is the same for the regular 750 channel memories, even though the freq field is the only significant one for the VFO scan limits.. struct channel { bbcd freq[4]; bbcd offset[4]; u8 unknownA:4, tune_step:4; ... u8 unknown24:4, scramble:4; char name[7]; ul16 custtone; }; ... #seekto 0x2000; struct channel memory[750]; ... #seekto 0x7DC0; struct { channel low_limit; channel high_limit; } vfo_scan_limits[5]; This gets me: File "c:\proj\proj_chirp\chirp\chirp\bitwise_grammar.py", line 134, in parse return pypeg_parse(_language, FakeFileInput()) File "c:\proj\proj_chirp\chirp\chirp\pyPEG.py", line 388, in parse raise SyntaxError("syntax error in " + u(file) + ":" + File "<string>", line None SyntaxError: syntax error in input:116: channel low_limit; Is this just a bug in the grammar? Or, is my definition of five pairs too complicated for bitwise? Should I stick to an array of 10 scalars, and do the odd/even math in my code? Easy enough, but not nearly as elegant. #seekto 0x7DC0; struct channel vfo_scan_limits[10]; Thanks -- This email has been checked for viruses by AVG antivirus software. www.avg.com

2 2

Re: [chirp_devel] Implementing Banks in CHIRP Driver
by Craig Jones 30 May '23

30 May '23

Implementing get_bank(), set_bank(), and clear_bank() in the radio class adheres to the separation-of-concerns principle by adding a level of abstraction. The radio class "owns" the memory structure, so it's in charge of the details of how it associates a memory with a bank. The BankModel class is there for the UI. The UI only cares about the fact that a memory is associated with a bank, but couldn't care less how the association is recorded in the radio's memory. BTW, did you really mean 0 through 21? Or, 0 through 20, or 1 through 21? On 5/29/2023 12:38 PM, Joseph Scanlan wrote: > Why did you choose to implement get_bank(), set_bank(), and > clear_bank() in the radio class instead of the bank model class? > > I could add this to my description instead: > > For example, with 4 banks, if we have bank capacity’s of [21, 4, > 0, 3] then memories 0 through 21 belong to Bank 1, memories 22 > through 25 belong to Bank 2, memories 26 through 28 belong to Bank > 4, and the remaining memories don’t belong to any bank. > > > With land mobile radios, the radio user can’t change much. The radio > tech programs the radios. The typical ham will fill both roles. > > When a tech uses the Icom software, they see a page for each bank and > can add, delete, move, and edit frequencies in the bank. This gives > the tech the ability to place channels in any order. They don’t see > the entire list of memories at once. > >> On May 28, 2023, at 20:21, Craig Jones via chirp_devel >> <chirp_devel(a)intrepid.danplanet.com> wrote: >> >> Do I understand correctly that you could add this to the description? >> >> For example, if the banks[16] array contains >> [2,3,5,7,0,0,0,0,0,...] then that means that memory[0:2] belong >> to Bank A, memory[2:5] belong to Bank B, memory[5:10] to C, >> memory[10:17] to D, and memory[17:] aren't in any bank. >> >> If so, that's wild, with wacky implications: >> >> * I don't see a logical location number in the mem struct, so that >> means the "Location Number" of every channel is constantly >> changing when you add/remove a channel to a bank? >> * It also means the user can't control the order of the memory >> locations? >> * At first, I was thinking that you would keep a cross-indexing >> array in your bank model which gets populated on the way in >> (download or file load) and interpreted on the way out (upload or >> save), but I guess you'll actually have to rearrange memory with >> every bank change if the UI is going to be able to keep up in >> real time. >> * BTW, if my example is correct, the "capacity" is misleading. I'd >> change it to "current_count" or current_size >> >> On 5/28/2023 2:55 PM, Joseph Scanlan wrote: >>> Here is my class description. Does it make at least a little sense >>> to someone who hasn’t spent time with the driver? >>> >>> """ >>> The Icom land mobile bank model. >>> >>> The radio stores bank capacity in an array of 16 bit, unsigned >>> integers. There is no other mapping. This implies >>> - memories in a bank are contiguous, >>> - memories in a bank are in the order that they apear in the >>> "memory" array, >>> - each memory can only be in one bank, >>> - all memories not in a bank are at the end of the "memory" array. >>> Here, "memory" array refers to the struct in "MEM_FORMAT". >>> “”" >>> >>> Do all models look the same in the banks tab? This is what I see: >>> >>> <Banks tab.png> >>> >>> Thanks for the spelling correction. >>> >>>> On May 24, 2023, at 15:00, Craig Jones via chirp_devel >>>> <chirp_devel(a)intrepid.danplanet.com> wrote: >>>> >>>> I was wondering what "capacity" meant. So, if that's just the >>>> count, where is the actual linkage between the bank and the >>>> memories? Anyway, the Anytone model I'm working on right now is the >>>> same (each mem is limited to one bank, or none): >>>> >>>> classAnytoneBankModel(chirp_common.BankModel): >>>> """ >>>> The Anytone bank model, for the radios that support it, is that >>>> a memory >>>> channel can only belong to one bank at a time. There are 10 >>>> banks (A-J >>>> with no alternate names). The mapping is done in a block of >>>> bytes that >>>> correspond to the 750 memories (one byte per memory). The >>>> possible values >>>> are 0-9 (A-J) or 15 (x0F) for "off". >>>> """ >>>> def__init__(self, radio, name="Banks", num_banks=10, num_memories=750): >>>> super(AnytoneBankModel,self).__init__(radio,name) >>>> self._bank_bounds =range(num_banks) >>>> self._mem_bounds =range(1,num_memories +1) >>>> self._banks =[ >>>> chirp_common.Bank(self,i,string.ascii_uppercase[i]) fori >>>> inself._bank_bounds >>>> ] >>>> defget_num_mappings(self): >>>> returnlen(self._banks) >>>> defget_mappings(self): >>>> returnself._banks >>>> defadd_memory_to_mapping(self, memory, bank): >>>> self._radio.set_bank(memory.number,bank.get_index()) >>>> defremove_memory_from_mapping(self, memory, mapping): >>>> self._radio.clr_bank(memory.number) >>>> defget_mapping_memories(self, bank): >>>> """Returns a list of all memories assigned to the given bank""" >>>> memories =[] >>>> fori inself._mem_bounds: >>>> bank_index =self._radio.get_bank(i) >>>> ifbank_index isnotNoneandbank_index ==bank.get_index(): >>>> memories.append(self._radio.get_memory(i)) >>>> returnmemories >>>> defget_memory_mappings(self, memory): >>>> bank_index =self._radio.get_bank(memory.number) >>>> return[]ifbank_index isNoneelse[self._banks[bank_index]] >>>> >>>> BTW, "scrabmler_code" is misspelled. >>>> >>>> >>>> On 5/24/2023 1:52 PM, Joseph Scanlan wrote: >>>>> A memory can not be in more than one bank simultaneously. >>>>> >>>>> A memory need not be in a bank. >>>>> >>>>> Memories are stored sequentially starting from [0]. Each number in banks holds the count of memories in that bank. The count can be 0. So to find the start index of the first memory in a bank we have to sum the sizes of all previous banks. >>>>> >>>>>> On May 23, 2023, at 14:06, Craig Jones via chirp_devel<chirp_devel(a)intrepid.danplanet.com> wrote: >>>>>> >>>>>> I just went through that myself. The first two questions: 1. Can one >>>>>> memory belong to multiple banks simultaneously? 2. Does every memory >>>>>> have to belong to at least one bank? The answers determine which base >>>>>> class you use for the bank model. >>>>>> >>>>>> You need to implement a bank model so that Chirp can inquire, for >>>>>> example, which memories are in bank C? >>>>>> >>>>>> You also need to implement get_bank(), set_bank(), clear_bank() for a >>>>>> memory (in the radio class), which will be called by the bank model. >>>>>> >>>>>> Hopefully, that's enough to get you started. >>>>>> >>>>>> >>>>>> On 5/23/2023 1:47 PM, Joseph Scanlan via chirp_devel wrote: >>>>>>> Does anyone have an example that will help me understand MemoryMapping, MappingModel, Bank, and BankModel classes? I’m working on a driver for the Icom IC-F520 land mobile radio. >>>>>>> >>>>>>> The F520 has 256 channels and 16 banks. This is how they look in MEM_FORMAT: >>>>>>> >>>>>>> struct { >>>>>>> u16 capacity; >>>>>>> } banks[16]; >>>>>>> >>>>>>> >>>>>>> struct { >>>>>>> char name[10]; >>>>>>> u32 inhibit:1, >>>>>>> freq_rx:31; >>>>>>> u32 inhibit_tx:1, >>>>>>> freq_tx:31; >>>>>>> u8 rx_tone_off:1, >>>>>>> rx_tone_digital:1, >>>>>>> unk01:6; >>>>>>> u8 rx_tone; >>>>>>> u8 tx_tone_off:1, >>>>>>> tx_tone_digital:1, >>>>>>> unk02:6; >>>>>>> u8 tx_tone; >>>>>>> u8 unk03:3, >>>>>>> tot_on:1, >>>>>>> lockout_repeater:1, >>>>>>> lockout_busy:1, >>>>>>> power_rf:2; >>>>>>> u8 log_in:2, >>>>>>> log_out:2, >>>>>>> unk04:1, >>>>>>> text_on:1, >>>>>>> unk05:1, >>>>>>> two_tone_unk1:1; >>>>>>> u8 unk06:4, >>>>>>> two_tone_unk2:2 >>>>>>> auto_reset_a:1, >>>>>>> unk07:1; >>>>>>> u8 narrow:1, >>>>>>> scrambler_on:1, >>>>>>> scrambler_inhibit:1, >>>>>>> compander_on:1, >>>>>>> unk08:4; >>>>>>> u8 unk09; >>>>>>> u8 scrabmler_code; >>>>>>> u16 unk10; >>>>>>> u16 unk11; >>>>>>> u8 unk12:6, >>>>>>> two_tone_index:2; >>>>>>> } memory[256]; >>>>>>> _______________________________________________ >>>>>>> chirp_devel mailing list >>>>>>> chirp_devel(a)intrepid.danplanet.com >>>>>>> http://intrepid.danplanet.com/mailman/listinfo/chirp_devel >>>>>>> Developer docs:http://chirp.danplanet.com/projects/chirp/wiki/Developers >>>>>> -- >>>>>> This email has been checked for viruses by AVG antivirus software. >>>>>> www.avg.com >>>>>> _______________________________________________ >>>>>> chirp_devel mailing list >>>>>> chirp_devel(a)intrepid.danplanet.com >>>>>> http://intrepid.danplanet.com/mailman/listinfo/chirp_devel >>>>>> Developer docs:http://chirp.danplanet.com/projects/chirp/wiki/Developers >>>> >>>> <http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_cam…> >>>> Virus-free.www.avg.com >>>> <http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_cam…> >>>> >>>> >>>> <x-msg://1/#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2> >>>> _______________________________________________ >>>> chirp_devel mailing list >>>> chirp_devel(a)intrepid.danplanet.com >>>> http://intrepid.danplanet.com/mailman/listinfo/chirp_devel >>>> Developer docs: >>>> http://chirp.danplanet.com/projects/chirp/wiki/Developers >>> >> _______________________________________________ >> chirp_devel mailing list >> chirp_devel(a)intrepid.danplanet.com >> http://intrepid.danplanet.com/mailman/listinfo/chirp_devel >> Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers > -- This email has been checked for viruses by AVG antivirus software. www.avg.com

1 0

Re: [chirp_devel] Implementing Banks in CHIRP Driver
by Craig Jones 29 May '23

29 May '23

Do I understand correctly that you could add this to the description? For example, if the banks[16] array contains [2,3,5,7,0,0,0,0,0,...] then that means that memory[0:2] belong to Bank A, memory[2:5] belong to Bank B, memory[5:10] to C, memory[10:17] to D, and memory[17:] aren't in any bank. If so, that's wild, with wacky implications: * I don't see a logical location number in the mem struct, so that means the "Location Number" of every channel is constantly changing when you add/remove a channel to a bank? * It also means the user can't control the order of the memory locations? * At first, I was thinking that you would keep a cross-indexing array in your bank model which gets populated on the way in (download or file load) and interpreted on the way out (upload or save), but I guess you'll actually have to rearrange memory with every bank change if the UI is going to be able to keep up in real time. * BTW, if my example is correct, the "capacity" is misleading. I'd change it to "current_count" or current_size On 5/28/2023 2:55 PM, Joseph Scanlan wrote: > Here is my class description. Does it make at least a little sense to > someone who hasn’t spent time with the driver? > > """ > > The Icom land mobile bank model. > > > The radio stores bank capacity in an array of 16 bit, unsigned > > integers. There is no other mapping. This implies > > - memories in a bank are contiguous, > > - memories in a bank are in the order that they apear in the > > "memory" array, > > - each memory can only be in one bank, > > - all memories not in a bank are at the end of the "memory" array. > > Here, "memory" array refers to the struct in "MEM_FORMAT". > > “”" > > > Do all models look the same in the banks tab? This is what I see: > > > Banks tab.png > > Thanks for the spelling correction. > >> On May 24, 2023, at 15:00, Craig Jones via chirp_devel >> <chirp_devel(a)intrepid.danplanet.com> wrote: >> >> I was wondering what "capacity" meant. So, if that's just the count, >> where is the actual linkage between the bank and the memories? >> Anyway, the Anytone model I'm working on right now is the same (each >> mem is limited to one bank, or none): >> >> classAnytoneBankModel(chirp_common.BankModel): >> """ >> The Anytone bank model, for the radios that support it, is that a >> memory >> channel can only belong to one bank at a time. There are 10 banks >> (A-J >> with no alternate names). The mapping is done in a block of bytes >> that >> correspond to the 750 memories (one byte per memory). The >> possible values >> are 0-9 (A-J) or 15 (x0F) for "off". >> """ >> def__init__(self, radio, name="Banks", num_banks=10, num_memories=750): >> super(AnytoneBankModel,self).__init__(radio,name) >> self._bank_bounds =range(num_banks) >> self._mem_bounds =range(1,num_memories +1) >> self._banks =[ >> chirp_common.Bank(self,i,string.ascii_uppercase[i]) fori >> inself._bank_bounds >> ] >> defget_num_mappings(self): >> returnlen(self._banks) >> defget_mappings(self): >> returnself._banks >> defadd_memory_to_mapping(self, memory, bank): >> self._radio.set_bank(memory.number,bank.get_index()) >> defremove_memory_from_mapping(self, memory, mapping): >> self._radio.clr_bank(memory.number) >> defget_mapping_memories(self, bank): >> """Returns a list of all memories assigned to the given bank""" >> memories =[] >> fori inself._mem_bounds: >> bank_index =self._radio.get_bank(i) >> ifbank_index isnotNoneandbank_index ==bank.get_index(): >> memories.append(self._radio.get_memory(i)) >> returnmemories >> defget_memory_mappings(self, memory): >> bank_index =self._radio.get_bank(memory.number) >> return[]ifbank_index isNoneelse[self._banks[bank_index]] >> >> BTW, "scrabmler_code" is misspelled. >> >> >> On 5/24/2023 1:52 PM, Joseph Scanlan wrote: >>> A memory can not be in more than one bank simultaneously. >>> >>> A memory need not be in a bank. >>> >>> Memories are stored sequentially starting from [0]. Each number in banks holds the count of memories in that bank. The count can be 0. So to find the start index of the first memory in a bank we have to sum the sizes of all previous banks. >>> >>>> On May 23, 2023, at 14:06, Craig Jones via chirp_devel<chirp_devel(a)intrepid.danplanet.com> wrote: >>>> >>>> I just went through that myself. The first two questions: 1. Can one >>>> memory belong to multiple banks simultaneously? 2. Does every memory >>>> have to belong to at least one bank? The answers determine which base >>>> class you use for the bank model. >>>> >>>> You need to implement a bank model so that Chirp can inquire, for >>>> example, which memories are in bank C? >>>> >>>> You also need to implement get_bank(), set_bank(), clear_bank() for a >>>> memory (in the radio class), which will be called by the bank model. >>>> >>>> Hopefully, that's enough to get you started. >>>> >>>> >>>> On 5/23/2023 1:47 PM, Joseph Scanlan via chirp_devel wrote: >>>>> Does anyone have an example that will help me understand MemoryMapping, MappingModel, Bank, and BankModel classes? I’m working on a driver for the Icom IC-F520 land mobile radio. >>>>> >>>>> The F520 has 256 channels and 16 banks. This is how they look in MEM_FORMAT: >>>>> >>>>> struct { >>>>> u16 capacity; >>>>> } banks[16]; >>>>> >>>>> >>>>> struct { >>>>> char name[10]; >>>>> u32 inhibit:1, >>>>> freq_rx:31; >>>>> u32 inhibit_tx:1, >>>>> freq_tx:31; >>>>> u8 rx_tone_off:1, >>>>> rx_tone_digital:1, >>>>> unk01:6; >>>>> u8 rx_tone; >>>>> u8 tx_tone_off:1, >>>>> tx_tone_digital:1, >>>>> unk02:6; >>>>> u8 tx_tone; >>>>> u8 unk03:3, >>>>> tot_on:1, >>>>> lockout_repeater:1, >>>>> lockout_busy:1, >>>>> power_rf:2; >>>>> u8 log_in:2, >>>>> log_out:2, >>>>> unk04:1, >>>>> text_on:1, >>>>> unk05:1, >>>>> two_tone_unk1:1; >>>>> u8 unk06:4, >>>>> two_tone_unk2:2 >>>>> auto_reset_a:1, >>>>> unk07:1; >>>>> u8 narrow:1, >>>>> scrambler_on:1, >>>>> scrambler_inhibit:1, >>>>> compander_on:1, >>>>> unk08:4; >>>>> u8 unk09; >>>>> u8 scrabmler_code; >>>>> u16 unk10; >>>>> u16 unk11; >>>>> u8 unk12:6, >>>>> two_tone_index:2; >>>>> } memory[256]; >>>>> _______________________________________________ >>>>> chirp_devel mailing list >>>>> chirp_devel(a)intrepid.danplanet.com >>>>> http://intrepid.danplanet.com/mailman/listinfo/chirp_devel >>>>> Developer docs:http://chirp.danplanet.com/projects/chirp/wiki/Developers >>>> -- >>>> This email has been checked for viruses by AVG antivirus software. >>>> www.avg.com >>>> _______________________________________________ >>>> chirp_devel mailing list >>>> chirp_devel(a)intrepid.danplanet.com >>>> http://intrepid.danplanet.com/mailman/listinfo/chirp_devel >>>> Developer docs:http://chirp.danplanet.com/projects/chirp/wiki/Developers >> >> <http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_cam…> >> Virus-free.www.avg.com >> <http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_cam…> >> >> >> <x-msg://1/#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2> >> _______________________________________________ >> chirp_devel mailing list >> chirp_devel(a)intrepid.danplanet.com >> http://intrepid.danplanet.com/mailman/listinfo/chirp_devel >> Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers > -- This email has been checked for viruses by AVG antivirus software. www.avg.com

1 0

Re: [chirp_devel] Implementing Banks in CHIRP Driver
by Craig Jones 24 May '23

24 May '23

I was wondering what "capacity" meant. So, if that's just the count, where is the actual linkage between the bank and the memories? Anyway, the Anytone model I'm working on right now is the same (each mem is limited to one bank, or none): classAnytoneBankModel(chirp_common.BankModel): """ The Anytone bank model, for the radios that support it, is that a memory channel can only belong to one bank at a time. There are 10 banks (A-J with no alternate names). The mapping is done in a block of bytes that correspond to the 750 memories (one byte per memory). The possible values are 0-9 (A-J) or 15 (x0F) for "off". """ def__init__(self, radio, name="Banks", num_banks=10, num_memories=750): super(AnytoneBankModel,self).__init__(radio,name) self._bank_bounds =range(num_banks) self._mem_bounds =range(1,num_memories +1) self._banks =[ chirp_common.Bank(self,i,string.ascii_uppercase[i]) fori inself._bank_bounds ] defget_num_mappings(self): returnlen(self._banks) defget_mappings(self): returnself._banks defadd_memory_to_mapping(self, memory, bank): self._radio.set_bank(memory.number,bank.get_index()) defremove_memory_from_mapping(self, memory, mapping): self._radio.clr_bank(memory.number) defget_mapping_memories(self, bank): """Returns a list of all memories assigned to the given bank""" memories =[] fori inself._mem_bounds: bank_index =self._radio.get_bank(i) ifbank_index isnotNoneandbank_index ==bank.get_index(): memories.append(self._radio.get_memory(i)) returnmemories defget_memory_mappings(self, memory): bank_index =self._radio.get_bank(memory.number) return[]ifbank_index isNoneelse[self._banks[bank_index]] BTW, "scrabmler_code" is misspelled. On 5/24/2023 1:52 PM, Joseph Scanlan wrote: > A memory can not be in more than one bank simultaneously. > > A memory need not be in a bank. > > Memories are stored sequentially starting from [0]. Each number in banks holds the count of memories in that bank. The count can be 0. So to find the start index of the first memory in a bank we have to sum the sizes of all previous banks. > >> On May 23, 2023, at 14:06, Craig Jones via chirp_devel<chirp_devel(a)intrepid.danplanet.com> wrote: >> >> I just went through that myself. The first two questions: 1. Can one >> memory belong to multiple banks simultaneously? 2. Does every memory >> have to belong to at least one bank? The answers determine which base >> class you use for the bank model. >> >> You need to implement a bank model so that Chirp can inquire, for >> example, which memories are in bank C? >> >> You also need to implement get_bank(), set_bank(), clear_bank() for a >> memory (in the radio class), which will be called by the bank model. >> >> Hopefully, that's enough to get you started. >> >> >> On 5/23/2023 1:47 PM, Joseph Scanlan via chirp_devel wrote: >>> Does anyone have an example that will help me understand MemoryMapping, MappingModel, Bank, and BankModel classes? I’m working on a driver for the Icom IC-F520 land mobile radio. >>> >>> The F520 has 256 channels and 16 banks. This is how they look in MEM_FORMAT: >>> >>> struct { >>> u16 capacity; >>> } banks[16]; >>> >>> >>> struct { >>> char name[10]; >>> u32 inhibit:1, >>> freq_rx:31; >>> u32 inhibit_tx:1, >>> freq_tx:31; >>> u8 rx_tone_off:1, >>> rx_tone_digital:1, >>> unk01:6; >>> u8 rx_tone; >>> u8 tx_tone_off:1, >>> tx_tone_digital:1, >>> unk02:6; >>> u8 tx_tone; >>> u8 unk03:3, >>> tot_on:1, >>> lockout_repeater:1, >>> lockout_busy:1, >>> power_rf:2; >>> u8 log_in:2, >>> log_out:2, >>> unk04:1, >>> text_on:1, >>> unk05:1, >>> two_tone_unk1:1; >>> u8 unk06:4, >>> two_tone_unk2:2 >>> auto_reset_a:1, >>> unk07:1; >>> u8 narrow:1, >>> scrambler_on:1, >>> scrambler_inhibit:1, >>> compander_on:1, >>> unk08:4; >>> u8 unk09; >>> u8 scrabmler_code; >>> u16 unk10; >>> u16 unk11; >>> u8 unk12:6, >>> two_tone_index:2; >>> } memory[256]; >>> _______________________________________________ >>> chirp_devel mailing list >>> chirp_devel(a)intrepid.danplanet.com >>> http://intrepid.danplanet.com/mailman/listinfo/chirp_devel >>> Developer docs:http://chirp.danplanet.com/projects/chirp/wiki/Developers >> -- >> This email has been checked for viruses by AVG antivirus software. >> www.avg.com >> _______________________________________________ >> chirp_devel mailing list >> chirp_devel(a)intrepid.danplanet.com >> http://intrepid.danplanet.com/mailman/listinfo/chirp_devel >> Developer docs:http://chirp.danplanet.com/projects/chirp/wiki/Developers

1 0

[chirp_devel] Implementing Banks in CHIRP Driver
by Joseph Scanlan 23 May '23

23 May '23

Does anyone have an example that will help me understand MemoryMapping, MappingModel, Bank, and BankModel classes? I’m working on a driver for the Icom IC-F520 land mobile radio. The F520 has 256 channels and 16 banks. This is how they look in MEM_FORMAT: struct { u16 capacity; } banks[16]; struct { char name[10]; u32 inhibit:1, freq_rx:31; u32 inhibit_tx:1, freq_tx:31; u8 rx_tone_off:1, rx_tone_digital:1, unk01:6; u8 rx_tone; u8 tx_tone_off:1, tx_tone_digital:1, unk02:6; u8 tx_tone; u8 unk03:3, tot_on:1, lockout_repeater:1, lockout_busy:1, power_rf:2; u8 log_in:2, log_out:2, unk04:1, text_on:1, unk05:1, two_tone_unk1:1; u8 unk06:4, two_tone_unk2:2 auto_reset_a:1, unk07:1; u8 narrow:1, scrambler_on:1, scrambler_inhibit:1, compander_on:1, unk08:4; u8 unk09; u8 scrabmler_code; u16 unk10; u16 unk11; u8 unk12:6, two_tone_index:2; } memory[256];

2 1

[chirp_devel] Is FLAKE8 line length 80 still appropriate?
by Craig Jones 22 May '23

22 May '23

Is there any particular reason why we're sticking to the FLAKE8 default of 80 character lines? The first thing I always do is change it to 160. 80 is just too tight for expressive names. Every single line ends up getting continued. Sometimes you even have to do battle with the enforced "visually pleasing" indents that can reduce the functional line length to 40 or less. -- This email has been checked for viruses by AVG antivirus software. www.avg.com

4 5

[chirp_devel] Quansheng UV-K5 driver
by Jacek Lipkowski 21 May '23

21 May '23

Hello, I've written an experimental driver for the Quansheng UV-K5, avaliable here: https://github.com/sq5bpf/uvk5-reverse-engineering/blob/main/uvk5.py This works in chirp-next 20230515, the specifica version that i use is: CHIRP next-20230515 on Python 3.11.2 wxPython 4.2.0 gtk3 (phoenix) wxWidgets 3.2.2 Let me know if there are any issues with it (coding standards etc). I will submit a pull request later. VY 73 Jacek / SQ5BPF

1 0

[chirp_devel] Adding columns to channel list
by Jacek Lipkowski 19 May '23

19 May '23

Hello, I have a question if it is possible to add/hide columns in the memory browser? This may be an obvious question, but i'm new to chirp development. I'm writing a driver for the Quansheng UV-K5, and this radio has a lot of features settable for every channel. I know that i can add an extra RadioSettingGroup to a channel, but it's only visible after right-clicking the channel. Now i can't expect the user to right-click every one of 200 channels to change or even see these settings. The only way i've found so far to let the users see these extra settings is to stuff them into the comment field, which is not pretty. I'm using CHIRP next-20230515 on Python 3.11.2 wxPython 4.2.0 gtk3 (phoenix) wxWidgets 3.2.2 on Debian 12 (almost-stable :). VY 73 Jacek / SQ5BPF

2 2