- Developers - lists.chirpmyradio.com

[chirp_devel] [PATCH] Add option for hardware flow control (rtscts) for Radio drivers, defaults to off
by Tom Hayward 15 Mar '12

15 Mar '12

# HG changeset patch # User Tom Hayward <tom(a)tomh.us> # Date 1331849254 21600 # Node ID 74a1811fdcb6a778a879393cccdf5052bbd70df7 # Parent 4b28a898abc415eee561a358875f6298c1387573 Add option for hardware flow control (rtscts) for Radio drivers, defaults to off. diff -r 4b28a898abc4 -r 74a1811fdcb6 chirp/chirp_common.py --- a/chirp/chirp_common.py Wed Mar 14 17:38:34 2012 -0600 +++ b/chirp/chirp_common.py Thu Mar 15 16:07:34 2012 -0600 @@ -760,6 +760,7 @@ class Radio: BAUD_RATE = 9600 + HARDWARE_FLOW = False VENDOR = "Unknown" MODEL = "Unknown" VARIANT = "" diff -r 4b28a898abc4 -r 74a1811fdcb6 chirpui/mainapp.py --- a/chirpui/mainapp.py Wed Mar 14 17:38:34 2012 -0600 +++ b/chirpui/mainapp.py Thu Mar 15 16:07:34 2012 -0600 @@ -622,6 +622,7 @@ try: ser = serial.Serial(port=settings.port, baudrate=settings.radio_class.BAUD_RATE, + rtscts=settings.radio_class.HARDWARE_FLOW, timeout=0.25) ser.flushInput() except serial.SerialException, e: @@ -655,6 +656,7 @@ try: ser = serial.Serial(port=settings.port, baudrate=radio.BAUD_RATE, + rtscts=radio.HARDWARE_FLOW, timeout=0.25) ser.flushInput() except serial.SerialException, e:

1 0

[chirp_devel] [PATCH] [thd72] Add live driver for Kenwood TH-D72 and disable broken clone driver.
by Tom Hayward 14 Mar '12

14 Mar '12

# HG changeset patch # User Tom Hayward <tom(a)tomh.us> # Date 1331766827 21600 # Node ID 6a44e4de4ec4775744f9d469cb8505e51448a81b # Parent 02e3e9f109445789e64b2f974b203833a9dfbba7 [thd72] Add live driver for Kenwood TH-D72 and disabled broken clone driver. diff -r 02e3e9f10944 -r 6a44e4de4ec4 chirp/kenwood_live.py --- a/chirp/kenwood_live.py Wed Mar 14 17:04:55 2012 -0600 +++ b/chirp/kenwood_live.py Wed Mar 14 17:13:47 2012 -0600 @@ -544,7 +544,7 @@ rf.valid_modes = D710_MODES rf.valid_duplexes = D710_DUPLEX rf.valid_tuning_steps = D710_STEPS - rf.valid_characters = chirp_common.CHARSET_ALPHANUMERIC + rf.valid_characters = chirp_common.CHARSET_ASCII.replace(',','') rf.valid_name_length = 8 rf.memory_bounds = (0, 999) return rf @@ -612,6 +612,62 @@ return spec @directory.register +class THD72Radio(TMD710Radio): + MODEL = "TH-D72" + + def _parse_mem_spec(self, spec): + mem = chirp_common.Memory() + + mem.number = int(spec[0]) + mem.freq = int(spec[1]) + mem.tuning_step = D710_STEPS[int(spec[2], 16)] + mem.duplex = D710_DUPLEX[int(spec[3])] + # Reverse + if int(spec[5]): + mem.tmode = "Tone" + elif int(spec[6]): + mem.tmode = "TSQL" + elif int(spec[7]): + mem.tmode = "DTCS" + mem.rtone = chirp_common.TONES[int(spec[9])] + mem.ctone = chirp_common.TONES[int(spec[10])] + mem.dtcs = chirp_common.DTCS_CODES[int(spec[11])] + mem.offset = int(spec[13]) + mem.mode = D710_MODES[int(spec[14])] + # TX Frequency + if int(spec[15]): + mem.duplex = "split" + mem.offset = int(spec[15]) + # Lockout + mem.skip = D710_SKIP[int(spec[17])] # Memory Lockout + + return mem + + def _make_mem_spec(self, mem): + print "Index %i for step %.2f" % (chirp_common.TUNING_STEPS.index(mem.tuning_step), mem.tuning_step) + spec = ( \ + "%010i" % mem.freq, + "%X" % D710_STEPS.index(mem.tuning_step), + "%i" % (0 if mem.duplex == "split" else D710_DUPLEX.index(mem.duplex)), + "0", # Reverse + "%i" % (mem.tmode == "Tone" and 1 or 0), + "%i" % (mem.tmode == "TSQL" and 1 or 0), + "%i" % (mem.tmode == "DTCS" and 1 or 0), + "0", + "%02i" % (chirp_common.TONES.index(mem.rtone)), + "%02i" % (chirp_common.TONES.index(mem.ctone)), + "%03i" % (chirp_common.DTCS_CODES.index(mem.dtcs)), + "0", + "%08i" % (0 if mem.duplex == "split" else mem.offset), # Offset + "%i" % D710_MODES.index(mem.mode), + "%010i" % (mem.offset if mem.duplex == "split" else 0), # TX Frequency + "0", # Unknown + "%i" % D710_SKIP.index(mem.skip), # Memory Lockout + ) + + return spec + +(a)directory.register class TMV71Radio(TMD710Radio): MODEL = "TM-V71" diff -r 02e3e9f10944 -r 6a44e4de4ec4 chirp/thd72.py --- a/chirp/thd72.py Wed Mar 14 17:04:55 2012 -0600 +++ b/chirp/thd72.py Wed Mar 14 17:13:47 2012 -0600 @@ -160,7 +160,7 @@ EXCH_W = "W\x00\x00\x00\x00" -(a)directory.register +#(a)directory.register class THD72Radio(chirp_common.CloneModeRadio): BAUD_RATE = 9600 VENDOR = "Kenwood"

1 0

[chirp_devel] [PATCH] Add buttons to Import/Export dialog for +10, +100, -10, and -100 adjustments.
by Tom Hayward 14 Mar '12

14 Mar '12

# HG changeset patch # User Tom Hayward <tom(a)tomh.us> # Date 1331755024 21600 # Node ID 71af287822ea4c94b608403026ee69d19bb79a37 # Parent 8d5c5ad69def733a4a6d7923c9588a47bae725ba Add buttons to Import/Export dialog for +10, +100, -10, and -100 adjustments. diff -r 8d5c5ad69def -r 71af287822ea chirpui/importdialog.py --- a/chirpui/importdialog.py Tue Mar 13 18:45:51 2012 -0700 +++ b/chirpui/importdialog.py Wed Mar 14 13:57:04 2012 -0600 @@ -401,6 +401,18 @@ def make_adjust(self): hbox = gtk.HBox(True, 2) + incr = gtk.Button("+100") + incr.connect("clicked", self.__incrnew, 100) + incr.set_size_request(50, 25) + incr.show() + hbox.pack_start(incr, 0, 0, 0) + + incr = gtk.Button("+10") + incr.connect("clicked", self.__incrnew, 10) + incr.set_size_request(50, 25) + incr.show() + hbox.pack_start(incr, 0, 0, 0) + incr = gtk.Button("+1") incr.connect("clicked", self.__incrnew, 1) incr.set_size_request(50, 25) @@ -413,6 +425,18 @@ decr.show() hbox.pack_start(decr, 0, 0, 0) + decr = gtk.Button("-10") + decr.connect("clicked", self.__incrnew, -10) + decr.set_size_request(50, 25) + decr.show() + hbox.pack_start(decr, 0, 0, 0) + + decr = gtk.Button("-100") + decr.connect("clicked", self.__incrnew, -100) + decr.set_size_request(50, 25) + decr.show() + hbox.pack_start(decr, 0, 0, 0) + auto = gtk.Button(_("Auto")) auto.connect("clicked", self.__autonew) auto.set_size_request(50, 25) @@ -449,7 +473,7 @@ return frame def make_controls(self): - hbox = gtk.HBox(True, 2) + hbox = gtk.HBox(False, 2) hbox.pack_start(self.make_select(), 0, 0, 0) hbox.pack_start(self.make_adjust(), 0, 0, 0)

1 0

[chirp_devel] [PATCH] [vx8] Remove bank memberships when deleting a memory
by Dan Smith 14 Mar '12

14 Mar '12

# HG changeset patch # User Dan Smith <dsmith(a)danplanet.com> # Date 1331687014 25200 # Node ID e17248d93b8e2978df987346e1be8fa38f89c075 # Parent 4df6f2246d71dac29ff00e7f92a080002e0d9394 [vx8] Remove bank memberships when deleting a memory diff -r 4df6f2246d71 -r e17248d93b8e chirp/vx8.py --- a/chirp/vx8.py Tue Mar 13 17:35:04 2012 -0700 +++ b/chirp/vx8.py Tue Mar 13 18:03:34 2012 -0700 @@ -237,11 +237,17 @@ mem.set_raw("\x00" * (mem.size() / 8)) mem.unknown1 = 0x05 + def _debank(self, mem): + bm = self.get_bank_model() + for bank in bm.get_memory_banks(mem): + bm.remove_memory_from_bank(mem, bank) + def set_memory(self, mem): flag = self._memobj.flag[mem.number-1] was_empty = flag.flag == 0 if mem.empty: flag.flag = 0 + self._debank(mem) return if mem.freq < 30000000 or \

1 0

[chirp_devel] [PATCH 0 of 2] Bank Editor tweaks (rev 2)
by Dan Smith 14 Mar '12

14 Mar '12

Per Tom's review on IRC, these two patches are tweaked as noted in their commit messages.

1 2

[chirp_devel] [PATCH] Report failure to add a memory to a bank to the user
by Dan Smith 13 Mar '12

13 Mar '12

# HG changeset patch # User Dan Smith <dsmith(a)danplanet.com> # Date 1331672826 25200 # Node ID 8eb9ce5692f71b761379db7a40541f1296c1bc81 # Parent 6f7a8a5b277fe99dd0a533f494be8d4d39ea0ea7 Report failure to add a memory to a bank to the user diff -r 6f7a8a5b277f -r 8eb9ce5692f7 chirpui/bankedit.py --- a/chirpui/bankedit.py Tue Mar 13 13:52:00 2012 -0700 +++ b/chirpui/bankedit.py Tue Mar 13 14:07:06 2012 -0700 @@ -174,7 +174,12 @@ # Step 2: Update our notion of the memory's bank information self.refresh_memory(loc) - def do_bank_index(_null, memory): + def do_bank_index(result, memory): + if isinstance(result, Exception): + common.show_error("Failed to add {mem} to bank: {err}" + .format(mem=memory.number, + err=str(result))) + return # Step 3: Set the memory's bank index (maybe) if not self._rf.has_bank_index or index is None: return do_refresh_memory()

1 0

[chirp_devel] [PATCH] Fix bank UI to make empty memories insensitive. This improves the visual
by Dan Smith 13 Mar '12

13 Mar '12

# HG changeset patch # User Dan Smith <dsmith(a)danplanet.com> # Date 1331671920 25200 # Node ID 6f7a8a5b277fe99dd0a533f494be8d4d39ea0ea7 # Parent d2be8e490a18351c3c9239d63e332c1e5b6568a0 Fix bank UI to make empty memories insensitive. This improves the visual nature, but also prevents the UI from asking the driver to add blank memories to a bank if the user accidentally clicks in one of the boxes. diff -r d2be8e490a18 -r 6f7a8a5b277f chirpui/bankedit.py --- a/chirpui/bankedit.py Tue Mar 13 13:16:53 2012 -0700 +++ b/chirpui/bankedit.py Tue Mar 13 13:52:00 2012 -0700 @@ -137,9 +137,9 @@ ncols = len(self._cols) + len(self.banks) while iter: vals = self._store.get(iter, *tuple([n for n in range(0, ncols)])) - loc = vals[0] - index = vals[3] - banks = vals[4:] + loc = vals[self.C_LOC] + index = vals[self.C_INDEX] + banks = vals[self.C_BANKS:] if True in banks and banks.index(True) == bank: indexes.append(index) iter = self._store.iter_next(iter) @@ -156,7 +156,7 @@ def _toggled_cb(self, rend, path, colnum): # The bank index is the column number, minus the 3 label columns bank, name = self.banks[colnum - len(self._cols)] - loc, = self._store.get(self._store.get_iter(path), 0) + loc, = self._store.get(self._store.get_iter(path), self.C_LOC) if rend.get_active(): # Changing from True to False @@ -201,7 +201,7 @@ self.rthread.submit(job) def _index_edited_cb(self, rend, path, new): - loc, = self._store.get(self._store.get_iter(path), 0) + loc, = self._store.get(self._store.get_iter(path), self.C_LOC) def refresh_memory(*args): self.refresh_memory(loc) @@ -234,12 +234,23 @@ self.rthread = rthread self._rf = rthread.radio.get_features() - self._cols = [ + self._view_cols = [ (_("Loc"), TYPE_INT, gtk.CellRendererText, ), (_("Frequency"), TYPE_STRING, gtk.CellRendererText, ), (_("Name"), TYPE_STRING, gtk.CellRendererText, ), (_("Index"), TYPE_INT, gtk.CellRendererText, ), ] + + self._cols = [ + ("_filled", TYPE_BOOLEAN, None, ), + ] + self._view_cols + + self.C_FILLED = 0 + self.C_LOC = 1 + self.C_FREQ = 2 + self.C_NAME = 3 + self.C_INDEX = 4 + self.C_BANKS = 5 # and beyond cols = list(self._cols) @@ -254,13 +265,18 @@ colnum = 0 for label, dtype, rtype in cols: + if not rtype: + colnum += 1 + continue rend = rtype() if dtype == TYPE_BOOLEAN: rend.set_property("activatable", True) rend.connect("toggled", self._toggled_cb, colnum) - col = gtk.TreeViewColumn(label, rend, active=colnum) + col = gtk.TreeViewColumn(label, rend, active=colnum, + sensitive=self.C_FILLED) else: - col = gtk.TreeViewColumn(label, rend, text=colnum) + col = gtk.TreeViewColumn(label, rend, text=colnum, + sensitive=self.C_FILLED) self._view.append_column(col) if colnum == 2: @@ -278,7 +294,12 @@ for i in range(*self._rf.memory_bounds): iter = self._store.append() - self._store.set(iter, 0, i, 1, 0, 2, "", 3, 0) + self._store.set(iter, + self.C_FILLED, False, + self.C_LOC, i, + self.C_FREQ, 0, + self.C_NAME, "", + self.C_INDEX, 0) self.root = sw self._loaded = False @@ -286,11 +307,12 @@ def refresh_memory(self, number): def got_mem(memory, banks, indexes): iter = self._store.get_iter(self._number_to_path(memory.number)) - row = [0, memory.number, - 1, chirp_common.format_freq(memory.freq), - 2, memory.name, + row = [self.C_FILLED, not memory.empty, + self.C_LOC, memory.number, + self.C_FREQ, chirp_common.format_freq(memory.freq), + self.C_NAME, memory.name, # Hack for only one index right now - 3, indexes and indexes[0] or 0, + self.C_INDEX, indexes and indexes[0] or 0, ] for i in range(0, len(self.banks)): row.append(i + len(self._cols)) @@ -309,8 +331,9 @@ def refresh_banks(self, and_memories=False): def got_banks(): - for i in range(0, len(self.banks)): - col = self._view.get_column(i + len(self._cols)) + for i in range(len(self._cols) - len(self._view_cols), + len(self.banks)): + col = self._view.get_column(i + len(self._view_cols)) bank, name = self.banks[i] if name: col.set_title(name)

1 0

[chirp_devel] [PATCH] [vx5] bugfix: get_raw_memory() was off by one
by Tom Hayward 13 Mar '12

13 Mar '12

# HG changeset patch # User Tom Hayward <tom(a)tomh.us> # Date 1331656681 21600 # Node ID 8f99d3035d75fdb16ae2316fe051cac98c9f93e3 # Parent ab7e8cdfd61ab1603012ac9e55a405cebf34de08 [vx5] bugfix: get_raw_memory() was off by one diff -r ab7e8cdfd61a -r 8f99d3035d75 chirp/vx5.py --- a/chirp/vx5.py Mon Mar 12 18:59:34 2012 -0600 +++ b/chirp/vx5.py Tue Mar 13 10:38:01 2012 -0600 @@ -101,7 +101,7 @@ self._memobj = bitwise.parse(mem_format, self._mmap) def get_raw_memory(self, number): - return repr(self._memobj.memory[number]) + return repr(self._memobj.memory[number-1]) def get_memory(self, number): _mem = self._memobj.memory[number-1]

2 1

[chirp_devel] [PATCH] [vx5] bugfix, power levels, and 8-char names
by Tom Hayward 13 Mar '12

13 Mar '12

Here are 3 patches for the VX5 driver. I hope attachments work; I don't know how to use hg email! Here is a summary: changeset: 1395:693766bb1594 branch: vx5 tag: tip user: Tom Hayward KD7LXL <esarfl(a)gmail.com> date: Sat Mar 10 17:10:27 2012 -0700 summary: [vx5] allow 8-character names changeset: 1394:c0f877c47900 branch: vx5 user: Tom Hayward KD7LXL <esarfl(a)gmail.com> date: Sat Mar 10 16:41:25 2012 -0700 summary: [vx5] add power level support changeset: 1393:35b6ec0749d2 branch: vx5 parent: 954:09af2a62cf91 user: Tom Hayward KD7LXL <esarfl(a)gmail.com> date: Sat Mar 10 16:01:04 2012 -0700 summary: [vx5] bugfix: set non-empty memories visible. This last one was a significant bug. The VX5 has a bit for each memory called "visible". From the VX5, you can mask a memory, rendering it invisible. When chirp was creating a new memory, it was not setting this bit, so newly added memories were invisible! The original tester must have only tried editing existing memories where the "visible" bit was already set. Tom KD7LXL

2 3

[chirp_devel] [PATCH] Improve latitude/longitude entry
by Brad Ackerman 02 Mar '12

02 Mar '12

The attached patch adds support for a wider variety of latitude/longitude input formats in the RFinder search dialog. What should work: dd mm.m N/S/E/W dd mm ss.s N/S/E/W with any separator between the fields, and with or without a separator between the final group of digits and the direction. The parsing code is currently extremely permissive. It doesn't complain about seconds or minutes values greater than 60; it just adds them in (so 45 90 N produces the same result as 46 30 N). Should it care? I could see that decision going either way. -- Brad Ackerman N1MNB PGP: 0x9F49A373 brad(a)facefault.org <*> http://bsa.smugmug.com/ -- Brad Ackerman N1MNB PGP: 0x9F49A373 brad(a)facefault.org <*> http://bsa.smugmug.com/

2 1