January 2018 - Developers - lists.chirpmyradio.com

[chirp_devel] Patch: Icom IC-2730A
by Rhett Robinson 15 Jan '18

15 Jan '18

Hi, I've attached a patch file for the Icom IC-2730A (fixes #2745). There is also an image attached to the bug for tests. Please review and send feedback, especially on any suggested changes to how I've modified icf.py to support this radio, as it differs from previous Icom radios. 73, Rhett Robinson AG7KJ

2 9

[chirp_devel] [PATCH] Adds support for a raw-mode Icom driver. This is required for the IC-2730A (part
by Rhett Robinson 14 Jan '18

14 Jan '18

# HG changeset patch # User Rhett Robinson <rrhett(a)gmail.com> # Date 1515970948 28800 # Sun Jan 14 15:02:28 2018 -0800 # Node ID ebcb6aeda1b85ef516247e69b21c24d33cd1d423 # Parent 16dc67ee13d18c5645c0bdbe0d20d021da702492 Adds support for a raw-mode Icom driver. This is required for the IC-2730A (part of #2745). diff -r 16dc67ee13d1 -r ebcb6aeda1b8 chirp/drivers/icf.py --- a/chirp/drivers/icf.py Wed Jan 03 11:06:05 2018 -0500 +++ b/chirp/drivers/icf.py Sun Jan 14 15:02:28 2018 -0800 @@ -85,6 +85,7 @@ def _process_frames(self): if not self.data.startswith("\xFE\xFE"): + LOG.error("Out of sync with radio:\n%s" % util.hexprint(self.data)) raise errors.InvalidDataError("Out of sync with radio") elif len(self.data) < 5: return [] # Not enough data for a full frame @@ -134,11 +135,11 @@ return self._process_frames() -def get_model_data(pipe, mdata="\x00\x00\x00\x00"): - """Query the radio connected to @pipe for its model data""" - send_clone_frame(pipe, 0xe0, mdata, raw=True) +def get_model_data(radio, mdata="\x00\x00\x00\x00"): + """Query the @radio for its model data""" + send_clone_frame(radio, 0xe0, mdata) - stream = RadioStream(pipe) + stream = RadioStream(radio.pipe) frames = stream.get_frames() if len(frames) != 1: @@ -164,27 +165,11 @@ return resp -def send_clone_frame(pipe, cmd, data, raw=False, checksum=False): - """Send a clone frame with @cmd and @data to the radio attached - to @pipe""" - cs = 0 +def send_clone_frame(radio, cmd, data, checksum=False): + """Send a clone frame with @cmd and @data to the @radio""" + payload = radio.get_payload(data, checksum) - if raw: - hed = data - else: - hed = "" - for byte in data: - val = ord(byte) - hed += "%02X" % val - cs += val - - if checksum: - cs = ((cs ^ 0xFFFF) + 1) & 0xFF - cs = "%02X" % cs - else: - cs = "" - - frame = "\xfe\xfe\xee\xef%s%s%s\xfd" % (chr(cmd), hed, cs) + frame = "\xfe\xfe\xee\xef%s%s\xfd" % (chr(cmd), payload) if SAVE_PIPE: LOG.debug("Saving data...") @@ -197,30 +182,14 @@ # return frame pass - pipe.write(frame) + radio.pipe.write(frame) return frame -def process_bcd(bcddata): - """Convert BCD-encoded data to raw""" - data = "" - i = 0 - while i < range(len(bcddata)) and i+1 < len(bcddata): - try: - val = int("%s%s" % (bcddata[i], bcddata[i+1]), 16) - i += 2 - data += struct.pack("B", val) - except ValueError, e: - LOG.error("Failed to parse byte: %s" % e) - break - - return data - - -def process_data_frame(frame, _mmap): +def process_data_frame(radio, frame, _mmap): """Process a data frame, adding the payload to @_mmap""" - _data = process_bcd(frame.payload) + _data = radio.process_frame_payload(frame.payload) if len(_mmap) >= 0x10000: saddr, = struct.unpack(">I", _data[0:4]) length, = struct.unpack("B", _data[4]) @@ -264,7 +233,7 @@ def _clone_from_radio(radio): - md = get_model_data(radio.pipe) + md = get_model_data(radio) if md[0:4] != radio.get_model(): LOG.info("This model: %s" % util.hexprint(md[0:4])) @@ -274,8 +243,7 @@ if radio.is_hispeed(): start_hispeed_clone(radio, CMD_CLONE_OUT) else: - send_clone_frame(radio.pipe, CMD_CLONE_OUT, - radio.get_model(), raw=True) + send_clone_frame(radio, CMD_CLONE_OUT, radio.get_model()) LOG.debug("Sent clone frame") @@ -291,7 +259,7 @@ for frame in frames: if frame.cmd == CMD_CLONE_DAT: - src, dst = process_data_frame(frame, _mmap) + src, dst = process_data_frame(radio, frame, _mmap) if last_size != (dst - src): LOG.debug("ICF Size change from %i to %i at %04x" % (last_size, dst - src, src)) @@ -342,7 +310,7 @@ chunk = struct.pack(">HB", i, size) chunk += _mmap[i:i+size] - send_clone_frame(radio.pipe, + send_clone_frame(radio, CMD_CLONE_DAT, chunk, checksum=True) @@ -360,22 +328,22 @@ # Uncomment to save out a capture of what we actually write to the radio # SAVE_PIPE = file("pipe_capture.log", "w", 0) - md = get_model_data(radio.pipe) + md = get_model_data(radio) if md[0:4] != radio.get_model(): raise errors.RadioError("I can't talk to this model") # This mimics what the Icom software does, but isn't required and just # takes longer - # md = get_model_data(radio.pipe, model=md[0:2]+"\x00\x00") - # md = get_model_data(radio.pipe, model=md[0:2]+"\x00\x00") + # md = get_model_data(radio, mdata=md[0:2]+"\x00\x00") + # md = get_model_data(radio, mdata=md[0:2]+"\x00\x00") stream = RadioStream(radio.pipe) if radio.is_hispeed(): start_hispeed_clone(radio, CMD_CLONE_IN) else: - send_clone_frame(radio.pipe, CMD_CLONE_IN, radio.get_model(), raw=True) + send_clone_frame(radio, CMD_CLONE_IN, radio.get_model()) frames = [] @@ -384,7 +352,7 @@ break frames += stream.get_frames() - send_clone_frame(radio.pipe, CMD_CLONE_END, radio.get_endframe(), raw=True) + send_clone_frame(radio, CMD_CLONE_END, radio.get_endframe()) if SAVE_PIPE: SAVE_PIPE.close() @@ -409,6 +377,7 @@ try: return _clone_to_radio(radio) except Exception, e: + logging.exception("Failed to communicate with the radio") raise errors.RadioError("Failed to communicate with the radio: %s" % e) @@ -579,6 +548,13 @@ raise errors.RadioError("Out of slots in this bank") +def compute_checksum(data): + cs = 0 + for byte in data: + cs += ord(byte) + return ((cs ^ 0xFFFF) + 1) & 0xFF + + class IcomCloneModeRadio(chirp_common.CloneModeRadio): """Base class for Icom clone-mode radios""" VENDOR = "Icom" @@ -612,6 +588,31 @@ """Returns the ranges this radio likes to have in a clone""" return cls._ranges + def process_frame_payload(self, payload): + """Convert BCD-encoded data to raw""" + bcddata = payload + data = "" + i = 0 + while i+1 < len(bcddata): + try: + val = int("%s%s" % (bcddata[i], bcddata[i+1]), 16) + i += 2 + data += struct.pack("B", val) + except ValueError, e: + LOG.error("Failed to parse byte: %s" % e) + break + + return data + + def get_payload(self, data, checksum): + """Returns the data with optional checksum BCD-encoded for the radio.""" + payload = "" + for byte in data: + payload += "%02X" % ord(byte) + if checksum: + payload += "%02X" % compute_checksum(data) + return payload + def sync_in(self): self._mmap = clone_from_radio(self) self.process_mmap() @@ -646,6 +647,67 @@ return honor_speed_switch_setting(self, settings) +def flip_high_order_bit(data): + return [chr(ord(d) ^ 0x80) for d in list(data)] + + +def escape_raw_byte(byte): + """Escapes a raw byte for sending to the radio""" + # Certain bytes are used as control characters to the radio, so if one of + # these bytes is present in the stream to the radio, it gets escaped as + # 0xff followed by (byte & 0x0f) + if ord(byte) > 0xf9: + return "\xff%s" % (chr(ord(byte) & 0xf)) + return byte + + +def unescape_raw_bytes(escaped_data): + """Unescapes raw bytes from the radio.""" + data = "" + i = 0 + while i < len(escaped_data): + byte = escaped_data[i] + if byte == '\xff': + if i + 1 >= len(escaped_data): + raise errors.InvalidDataError( + "Unexpected escape character at end of data") + i += 1 + byte = chr(0xf0 | ord(escaped_data[i])) + data += byte + i += 1 + return data + + +class IcomRawCloneModeRadio(IcomCloneModeRadio): + """Subclass for Icom clone-mode radios using the raw data protocol.""" + + def process_frame_payload(self, payload): + """Payloads from a raw-clone-mode radio are already in raw format.""" + return unescape_raw_bytes(payload) + + def get_payload(self, data, checksum): + """Returns the data with optional checksum in raw format.""" + if checksum: + cs = chr(compute_checksum(data)) + else: + cs = "" + payload = "%s%s" % (data, cs) + # Escape control characters. + escaped_payload = [escape_raw_byte(b) for b in payload] + return "".join(escaped_payload) + + def sync_in(self): + # The radio returns all the bytes with the high-order bit flipped. + _mmap = clone_from_radio(self) + _mmap = flip_high_order_bit(_mmap.get_packed()) + self._mmap = memmap.MemoryMap(_mmap) + self.process_mmap() + + def get_mmap(self): + _data = flip_high_order_bit(self._mmap.get_packed()) + return memmap.MemoryMap(_data) + + class IcomLiveRadio(chirp_common.LiveRadio): """Base class for an Icom Live-mode radio""" VENDOR = "Icom"

1 0

[chirp_devel] [PATCH] [ic2730a] Add support for Icom IC-2730A. Fixes #2745
by Rhett Robinson 14 Jan '18

14 Jan '18

# HG changeset patch # User Rhett Robinson <rrhett(a)gmail.com> # Date 1515970977 28800 # Sun Jan 14 15:02:57 2018 -0800 # Node ID 30023a69e963ce27fbdbe2dd30fe5e5db0c7dfbe # Parent ebcb6aeda1b85ef516247e69b21c24d33cd1d423 [ic2730a] Add support for Icom IC-2730A. Fixes #2745. diff -r ebcb6aeda1b8 -r 30023a69e963 chirp/drivers/ic2730.py --- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/chirp/drivers/ic2730.py Sun Jan 14 15:02:57 2018 -0800 @@ -0,0 +1,273 @@ +# Copyright 2018 Rhett Robinson <rrhett(a)gmail.com> +# +# This program is free software: you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation, either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see <http://www.gnu.org/licenses/>. + +from chirp.drivers import icf +from chirp import chirp_common, util, directory, bitwise, memmap + + +# Still missing: +# - scan edges +# - priority watch +# - hope channel beep +# - DTMF memory +# - weather channel alert +MEM_FORMAT = """ +struct { + u24 freq; + u16 offset; + u8 tune_step:4, + unknown5:3, + mode:1; + u8 unknown6:2, + rtone:6; + u8 unknown7:2, + ctone:6; + u8 dtcs; + u8 dtcs1; + u8 tmode:4, + duplex:2, + dtcs_polarity:2; + char name[6]; +} memory[1002]; + +#seekto 0x42c0; +u8 used_flags[125]; + +#seekto 0x433e; +u8 skip_flags[125]; +u8 pskip_flags[125]; + +#seekto 0x4440; +struct { + u8 bank; + u8 index; +} bank_info[1000]; + +#seekto 0x4c50; +struct { + char name[6]; +} bank_names[10]; + +#seekto 0x5004; +u8 unknown12:4, + autorptr:2, + unknown13:2; + +#seekto 0x5030; +u8 unknown14:6, + backlight:2; + +#seekto 0x5056; +u8 unknown15:6, + power:2; + +#seekto 0x5220; +u16 left_memory; +u16 right_memory; + +#seekto 0x5280; +u16 mem_writes_count; +""" + +# Guessing some of these intermediate values are with the Pocket Beep function, +# but I haven't reliably reproduced these. +TMODES = ["", "Tone", "??0", "TSQL", "??1", "DTCS", "TSQL-R", "DTCS-R", + "DTC.OFF", "TON.DTC", "DTC.TSQ", "TON.TSQ"] +DUPLEX = ["", "-", "+"] +MODES = ["FM", "NFM"] +DTCSP = ["NN", "NR", "RN", "RR"] + +AUTOREPEATER = ["OFF", "DUP", "DUP.TON"] + + +class IC2730Bank(icf.IcomNamedBank): + """An IC2730 bank""" + def get_name(self): + _banks = self._model._radio._memobj.bank_names + return str(_banks[self.index].name).rstrip() + + def set_name(self, name): + _banks = self._model._radio._memobj.bank_names + _banks[self.index].name = str(name).ljust(6)[:6] + + +def _get_special(): + special = {"C0": 1000, + "C1": 1001} + return special + + +def _resolve_memory_number(number): + if isinstance(number, str): + return _get_special()[number] + else: + return number + + +def _wipe_memory(mem, char): + mem.set_raw(char * (mem.size() / 8)) + + +(a)directory.register +class IC2730Radio(icf.IcomRawCloneModeRadio): + """Icom IC-2730A""" + VENDOR = "Icom" + MODEL = "IC-2730A" + + _model = "\x35\x98\x00\x01" + _memsize = 21312 # 0x5340 + _endframe = "Icom Inc\x2e4E" + + _ranges = [(0x0000, 0x5300, 64), + (0x5300, 0x5310, 16), + (0x5310, 0x5340, 48), + ] + + _num_banks = 10 + _bank_class = IC2730Bank + _can_hispeed = True + + def _get_bank(self, loc): + _bank = self._memobj.bank_info[loc] + if _bank.bank == 0x1F: + return None + else: + return _bank.bank + + def _set_bank(self, loc, bank): + _bank = self._memobj.bank_info[loc] + if bank is None: + _bank.bank = 0x1F + else: + _bank.bank = bank + + def _get_bank_index(self, loc): + _bank = self._memobj.bank_info[loc] + return _bank.index + + def _set_bank_index(self, loc, index): + _bank = self._memobj.bank_info[loc] + _bank.index = index + + def get_features(self): + rf = chirp_common.RadioFeatures() + rf.has_settings = True + rf.has_bank_index = True + rf.has_bank_names = True + rf.requires_call_lists = False + rf.memory_bounds = (0, 999) + rf.valid_modes = list(MODES) + rf.valid_tmodes = list(TMODES) + rf.valid_duplexes = list(set(DUPLEX)) + rf.valid_tuning_steps = list(chirp_common.TUNING_STEPS[0:9]) + rf.valid_bands = [(118000000, 174000000), + (375000000, 550000000), + ] + rf.valid_skips = ["", "S", "P"] + rf.valid_characters = chirp_common.CHARSET_ASCII + rf.valid_name_length = 6 + rf.valid_special_chans = sorted(_get_special().keys()) + + return rf + + def process_mmap(self): + self._memobj = bitwise.parse(MEM_FORMAT, self._mmap) + + def get_memory(self, number): + bitpos = (1 << (number % 8)) + bytepos = number / 8 + + _mem = self._memobj.memory[number] + _used = self._memobj.used_flags[bytepos] + + is_used = ((_used & bitpos) == 0) + + mem = chirp_common.Memory() + + mem.number = number + + _skip = self._memobj.skip_flags[bytepos] + _pskip = self._memobj.pskip_flags[bytepos] + if _skip & bitpos: + mem.skip = "S" + elif _pskip & bitpos: + mem.skip = "P" + + if not is_used: + mem.empty = True + return mem + + # Frequencies are stored as kHz/5 + mem.freq = int(_mem.freq) * 5000 + mem.offset = int(_mem.offset) * 5000 + mem.rtone = chirp_common.TONES[_mem.rtone] + mem.ctone = chirp_common.TONES[_mem.ctone] + mem.tmode = TMODES[_mem.tmode] + mem.duplex = DUPLEX[_mem.duplex] + mem.mode = MODES[_mem.mode] + mem.dtcs = chirp_common.DTCS_CODES[_mem.dtcs] + mem.dtcs_polarity = DTCSP[_mem.dtcs_polarity] + if _mem.tune_step > 8: + mem.tuning_step = 5.0 # Sometimes TS is garbage? + else: + mem.tuning_step = chirp_common.TUNING_STEPS[_mem.tune_step] + mem.name = str(_mem.name).rstrip() + + return mem + + def set_memory(self, mem): + bitpos = (1 << (mem.number % 8)) + bytepos = mem.number / 8 + + _mem = self._memobj.memory[mem.number] + _used = self._memobj.used_flags[bytepos] + + was_empty = _used & bitpos + + skip = self._memobj.skip_flags[bytepos] + pskip = self._memobj.pskip_flags[bytepos] + if mem.skip == "S": + skip |= bitpos + else: + skip &= ~bitpos + if mem.skip == "P": + pskip |= bitpos + else: + pskip &= ~bitpos + + if mem.empty: + _used |= bitpos + _wipe_memory(_mem, "\xFF") + self._set_bank(mem.number, None) + return + + _used &= ~bitpos + if was_empty: + _wipe_memory(_mem, "\x00") + + _mem.freq = mem.freq / 5000 + _mem.offset = mem.offset / 5000 + _mem.rtone = chirp_common.TONES.index(mem.rtone) + _mem.ctone = chirp_common.TONES.index(mem.ctone) + _mem.tmode = TMODES.index(mem.tmode) + _mem.duplex = DUPLEX.index(mem.duplex) + _mem.mode = MODES.index(mem.mode) + _mem.dtcs = chirp_common.DTCS_CODES.index(mem.dtcs) + _mem.dtcs_polarity = DTCSP.index(mem.dtcs_polarity) + _mem.tune_step = chirp_common.TUNING_STEPS.index(mem.tuning_step) + _mem.name = mem.name.ljust(6) + + def get_raw_memory(self, number): + return repr(self._memobj.memory[number])

1 0

[chirp_devel] [PATCH] [ic2730a] Add support for Icom IC-2730A. Fixes #2745
by Rhett Robinson 14 Jan '18

14 Jan '18

# HG changeset patch # User Rhett Robinson <rrhett(a)gmail.com> # Date 1515970485 28800 # Sun Jan 14 14:54:45 2018 -0800 # Node ID 6ffdeb62bf3efde8a94ddd24109b9948185f832b # Parent 16dc67ee13d18c5645c0bdbe0d20d021da702492 [ic2730a] Add support for Icom IC-2730A. Fixes #2745 diff -r 16dc67ee13d1 -r 6ffdeb62bf3e chirp/drivers/icf.py --- a/chirp/drivers/icf.py Wed Jan 03 11:06:05 2018 -0500 +++ b/chirp/drivers/icf.py Sun Jan 14 14:54:45 2018 -0800 @@ -85,6 +85,7 @@ def _process_frames(self): if not self.data.startswith("\xFE\xFE"): + LOG.error("Out of sync with radio:\n%s" % util.hexprint(self.data)) raise errors.InvalidDataError("Out of sync with radio") elif len(self.data) < 5: return [] # Not enough data for a full frame @@ -134,11 +135,11 @@ return self._process_frames() -def get_model_data(pipe, mdata="\x00\x00\x00\x00"): - """Query the radio connected to @pipe for its model data""" - send_clone_frame(pipe, 0xe0, mdata, raw=True) +def get_model_data(radio, mdata="\x00\x00\x00\x00"): + """Query the @radio for its model data""" + send_clone_frame(radio, 0xe0, mdata) - stream = RadioStream(pipe) + stream = RadioStream(radio.pipe) frames = stream.get_frames() if len(frames) != 1: @@ -164,27 +165,11 @@ return resp -def send_clone_frame(pipe, cmd, data, raw=False, checksum=False): - """Send a clone frame with @cmd and @data to the radio attached - to @pipe""" - cs = 0 +def send_clone_frame(radio, cmd, data, checksum=False): + """Send a clone frame with @cmd and @data to the @radio""" + payload = radio.get_payload(data, checksum) - if raw: - hed = data - else: - hed = "" - for byte in data: - val = ord(byte) - hed += "%02X" % val - cs += val - - if checksum: - cs = ((cs ^ 0xFFFF) + 1) & 0xFF - cs = "%02X" % cs - else: - cs = "" - - frame = "\xfe\xfe\xee\xef%s%s%s\xfd" % (chr(cmd), hed, cs) + frame = "\xfe\xfe\xee\xef%s%s\xfd" % (chr(cmd), payload) if SAVE_PIPE: LOG.debug("Saving data...") @@ -197,30 +182,14 @@ # return frame pass - pipe.write(frame) + radio.pipe.write(frame) return frame -def process_bcd(bcddata): - """Convert BCD-encoded data to raw""" - data = "" - i = 0 - while i < range(len(bcddata)) and i+1 < len(bcddata): - try: - val = int("%s%s" % (bcddata[i], bcddata[i+1]), 16) - i += 2 - data += struct.pack("B", val) - except ValueError, e: - LOG.error("Failed to parse byte: %s" % e) - break - - return data - - -def process_data_frame(frame, _mmap): +def process_data_frame(radio, frame, _mmap): """Process a data frame, adding the payload to @_mmap""" - _data = process_bcd(frame.payload) + _data = radio.process_frame_payload(frame.payload) if len(_mmap) >= 0x10000: saddr, = struct.unpack(">I", _data[0:4]) length, = struct.unpack("B", _data[4]) @@ -264,7 +233,7 @@ def _clone_from_radio(radio): - md = get_model_data(radio.pipe) + md = get_model_data(radio) if md[0:4] != radio.get_model(): LOG.info("This model: %s" % util.hexprint(md[0:4])) @@ -274,8 +243,7 @@ if radio.is_hispeed(): start_hispeed_clone(radio, CMD_CLONE_OUT) else: - send_clone_frame(radio.pipe, CMD_CLONE_OUT, - radio.get_model(), raw=True) + send_clone_frame(radio, CMD_CLONE_OUT, radio.get_model()) LOG.debug("Sent clone frame") @@ -291,7 +259,7 @@ for frame in frames: if frame.cmd == CMD_CLONE_DAT: - src, dst = process_data_frame(frame, _mmap) + src, dst = process_data_frame(radio, frame, _mmap) if last_size != (dst - src): LOG.debug("ICF Size change from %i to %i at %04x" % (last_size, dst - src, src)) @@ -342,7 +310,7 @@ chunk = struct.pack(">HB", i, size) chunk += _mmap[i:i+size] - send_clone_frame(radio.pipe, + send_clone_frame(radio, CMD_CLONE_DAT, chunk, checksum=True) @@ -360,22 +328,22 @@ # Uncomment to save out a capture of what we actually write to the radio # SAVE_PIPE = file("pipe_capture.log", "w", 0) - md = get_model_data(radio.pipe) + md = get_model_data(radio) if md[0:4] != radio.get_model(): raise errors.RadioError("I can't talk to this model") # This mimics what the Icom software does, but isn't required and just # takes longer - # md = get_model_data(radio.pipe, model=md[0:2]+"\x00\x00") - # md = get_model_data(radio.pipe, model=md[0:2]+"\x00\x00") + # md = get_model_data(radio, mdata=md[0:2]+"\x00\x00") + # md = get_model_data(radio, mdata=md[0:2]+"\x00\x00") stream = RadioStream(radio.pipe) if radio.is_hispeed(): start_hispeed_clone(radio, CMD_CLONE_IN) else: - send_clone_frame(radio.pipe, CMD_CLONE_IN, radio.get_model(), raw=True) + send_clone_frame(radio, CMD_CLONE_IN, radio.get_model()) frames = [] @@ -384,7 +352,7 @@ break frames += stream.get_frames() - send_clone_frame(radio.pipe, CMD_CLONE_END, radio.get_endframe(), raw=True) + send_clone_frame(radio, CMD_CLONE_END, radio.get_endframe()) if SAVE_PIPE: SAVE_PIPE.close() @@ -409,6 +377,7 @@ try: return _clone_to_radio(radio) except Exception, e: + logging.exception("Failed to communicate with the radio") raise errors.RadioError("Failed to communicate with the radio: %s" % e) @@ -579,6 +548,13 @@ raise errors.RadioError("Out of slots in this bank") +def compute_checksum(data): + cs = 0 + for byte in data: + cs += ord(byte) + return ((cs ^ 0xFFFF) + 1) & 0xFF + + class IcomCloneModeRadio(chirp_common.CloneModeRadio): """Base class for Icom clone-mode radios""" VENDOR = "Icom" @@ -612,6 +588,31 @@ """Returns the ranges this radio likes to have in a clone""" return cls._ranges + def process_frame_payload(self, payload): + """Convert BCD-encoded data to raw""" + bcddata = payload + data = "" + i = 0 + while i+1 < len(bcddata): + try: + val = int("%s%s" % (bcddata[i], bcddata[i+1]), 16) + i += 2 + data += struct.pack("B", val) + except ValueError, e: + LOG.error("Failed to parse byte: %s" % e) + break + + return data + + def get_payload(self, data, checksum): + """Returns the data with optional checksum BCD-encoded for the radio.""" + payload = "" + for byte in data: + payload += "%02X" % ord(byte) + if checksum: + payload += "%02X" % compute_checksum(data) + return payload + def sync_in(self): self._mmap = clone_from_radio(self) self.process_mmap() @@ -646,6 +647,67 @@ return honor_speed_switch_setting(self, settings) +def flip_high_order_bit(data): + return [chr(ord(d) ^ 0x80) for d in list(data)] + + +def escape_raw_byte(byte): + """Escapes a raw byte for sending to the radio""" + # Certain bytes are used as control characters to the radio, so if one of + # these bytes is present in the stream to the radio, it gets escaped as + # 0xff followed by (byte & 0x0f) + if ord(byte) > 0xf9: + return "\xff%s" % (chr(ord(byte) & 0xf)) + return byte + + +def unescape_raw_bytes(escaped_data): + """Unescapes raw bytes from the radio.""" + data = "" + i = 0 + while i < len(escaped_data): + byte = escaped_data[i] + if byte == '\xff': + if i + 1 >= len(escaped_data): + raise errors.InvalidDataError( + "Unexpected escape character at end of data") + i += 1 + byte = chr(0xf0 | ord(escaped_data[i])) + data += byte + i += 1 + return data + + +class IcomRawCloneModeRadio(IcomCloneModeRadio): + """Subclass for Icom clone-mode radios using the raw data protocol.""" + + def process_frame_payload(self, payload): + """Payloads from a raw-clone-mode radio are already in raw format.""" + return unescape_raw_bytes(payload) + + def get_payload(self, data, checksum): + """Returns the data with optional checksum in raw format.""" + if checksum: + cs = chr(compute_checksum(data)) + else: + cs = "" + payload = "%s%s" % (data, cs) + # Escape control characters. + escaped_payload = [escape_raw_byte(b) for b in payload] + return "".join(escaped_payload) + + def sync_in(self): + # The radio returns all the bytes with the high-order bit flipped. + _mmap = clone_from_radio(self) + _mmap = flip_high_order_bit(_mmap.get_packed()) + self._mmap = memmap.MemoryMap(_mmap) + self.process_mmap() + + def get_mmap(self): + _data = flip_high_order_bit(self._mmap.get_packed()) + return memmap.MemoryMap(_data) + + class IcomLiveRadio(chirp_common.LiveRadio): """Base class for an Icom Live-mode radio""" VENDOR = "Icom"

1 1

[chirp_devel] Security BUG: Chirp is leaking users passwords in the debug.log
by Pavel Milanes 11 Jan '18

11 Jan '18

Hi Dan et al, I was working recently on a Chirp's issue and a user uploaded a debug.log for me... the debug.log has the passwords of an online service in plain text. the issue page was removed as per user request to maintain his privacy (I would had erased only the uploaded log and not the entire issue page, but I was offline at that time.) That is from any point of view a security risk and unacceptable, Chirp can't leak user's credentials. You can see a sample of a log (password obfuscated to "password" for security reason) in this comment: https://chirp.danplanet.com/issues/5481#note-11 I ask to Dan and others about the correct curse of action, as I see we have a few options: 1. Don't log the XML data at all (this will make difficult to debug it) 2. Parse the XML data output and remove/obfuscate the password before printing to debug.log 3. #2 plus some command line switch to only log the clear text credentials by demand of the user/dev. 4. Other? Number 2 is the obvious option, but I don't have a online account to test not the connectivity and time to test it. Who take it to fix it? Dan? Others? Maybe I'm with the paranoia setting to high... Cheers, Pavel. -- 73 CO7WT, Pavel.

2 1

[chirp_devel] Wouxung KG-UV950P quad band progress #1489
by Pavel Milanes 10 Jan '18

10 Jan '18

Hi to all. I did some tinkering with the serial logs and the crypt protocol is similar to the used by the KG-UV8D Plus, but the checksum of each packet is unknown yet. It has some different approach but I did manage to decode packet data, so there is an advance, notes and sample code are at home, so tomorrow will upload all of them. I managed to decode the ident packet and name of the radio is there and also limits for the 4 bands and other data... Just need to give the good news to the group, we have an advance on this one. Ron are you there? -- 73 CO7WT, Pavel.

2 1

[chirp_devel] RT Systems Radio Files
by dropkick23＠gmail.com 06 Jan '18

06 Jan '18

Any one have information on format of RT Systems Radio Data Files? Not CVS files but the files saved by their programming program. Thanks Fred

1 0

[chirp_devel] Wouxun KG-UV8E KG-UV8T KG-UV8D Plus
by D.J.J. Ring, Jr. 06 Jan '18

06 Jan '18

To all who have been following the work on Wouxun KG-UV8E issue #3943. I uploaded a debug log and I wasn't expecting my username and password to be in plain text, so the entire issue had to be deleted. (Thanks Dan) The project is moved: Wouxun KG-UV8E KG-UV8T KG-UV8D Plus <https://chirp.danplanet.com/issues/5481> https://chirp.danplanet.com/issues/5481 73 David N1EA

1 0

[chirp_devel] any Chirp developers in NJ, NY, or PA?
by Rob Owens 05 Jan '18

05 Jan '18

I now have three radios that are not supported by Chirp. Nobody has stepped up to add support, so I'm trying to teach myself how to do it. But I'm sure my learning curve would be much quicker if I had somebody experienced to work with for a day or so. Is there anybody near northwestern New Jersey who would be willing to help me get started? I'm not looking for someone to do the work for me, just somebody to help remove the cloud of uncertainty I'm stuck in. -Rob

5 12

[chirp_devel] driver file for Alinco DJ-500 with AnyTone protocol
by Patrick Strasser-Mikhail 03 Jan '18

03 Jan '18

Hi! I own an Alinco DJ-500, which at least in the programming protocal uses the AnyTone protocol. I've got it basically talking with the AnyTone driver, still fiddling arround with the memory layout. So the good news is it's not difficult to get it running with chirp (actually I've reverse-engineered the protocoll, and while half through I found out about the parallels with AnyTone, tried that and... let's say I learned a lot...) Now my question would be: Should the details be integrated in the AnyTone driver, or should the AnyTone driver be duplicated? BR/73 Patrick OE6PSE -- Engineers motto: cheap, good, fast - choose any two One of the lucky 10.000: http://xkcd.com/1053 Use Mail Encryption Today! PGP Key ID: 0xDF8A127E5A120903 Patrick Strasser-Mikhail <patrick at wirklich priv at>

2 1