November 2016 - Developers - lists.chirpmyradio.com

[chirp_devel] [PATCH] [UV-5X3] Add remaining DTMF Decode settings
by Jim Unroe 11 Nov '16

11 Nov '16

# HG changeset patch # User Jim Unroe <rock.unroe(a)gmail.com> # Date 1478905113 18000 # Node ID 1b62ad89d453ee26555704d9fe75767866adb48a # Parent c386ef4dc431e5065266de2b163260e6f5637b27 [UV-5X3] Add remaining DTMF Decode settings This patch adds the following settings to the BTech UV-5X3: - Group Code - Space Code related to #3931 diff -r c386ef4dc431 -r 1b62ad89d453 chirp/drivers/uv5x3.py --- a/chirp/drivers/uv5x3.py Tue Nov 01 18:42:18 2016 -0700 +++ b/chirp/drivers/uv5x3.py Fri Nov 11 17:58:33 2016 -0500 @@ -71,6 +71,8 @@ LIST_TXPOWER = ["High", "Low"] LIST_VOICE = ["Off", "English", "Chinese"] LIST_WORKMODE = ["Frequency", "Channel"] +LIST_DTMF_SPECIAL_DIGITS = [ "*", "#", "A", "B", "C", "D"] +LIST_DTMF_SPECIAL_VALUES = [ 0x0B, 0x0C, 0x0D, 0x0E, 0x0F, 0x00] def model_match(cls, data): """Match the opened/downloaded image to the correct version""" @@ -1119,6 +1121,27 @@ rs.set_apply_callback(apply_code, self._memobj.ani) dtmfd.append(rs) + def apply_dmtf_listvalue(setting, obj): + LOG.debug("Setting value: "+ str(setting.value) + " from list") + val = str(setting.value) + index = LIST_DTMF_SPECIAL_DIGITS.index(val) + val = LIST_DTMF_SPECIAL_VALUES[index] + obj.set_value(val) + + idx = LIST_DTMF_SPECIAL_VALUES.index(_mem.ani.groupcode) + rs = RadioSetting("ani.groupcode", "Group Code", + RadioSettingValueList(LIST_DTMF_SPECIAL_DIGITS, + LIST_DTMF_SPECIAL_DIGITS[idx])) + rs.set_apply_callback(apply_dmtf_listvalue, _mem.ani.groupcode) + dtmfd.append(rs) + + idx = LIST_DTMF_SPECIAL_VALUES.index(_mem.ani.spacecode) + rs = RadioSetting("ani.spacecode", "Space Code", + RadioSettingValueList(LIST_DTMF_SPECIAL_DIGITS, + LIST_DTMF_SPECIAL_DIGITS[idx])) + rs.set_apply_callback(apply_dmtf_listvalue, _mem.ani.spacecode) + dtmfd.append(rs) + if _mem.ani.resettime > 0x9F: val = 0x4F else:

1 0

[chirp_devel] [PATCH] Add TreeView into ScrolledWindow to prevent resize of window. #4209
by Michael Wagner (OE4AMW) 11 Nov '16

11 Nov '16

# HG changeset patch # User Michael Wagner <michael.wagner(a)gmx.at> # Date 1478903495 -3600 # Fri Nov 11 23:31:35 2016 +0100 # Node ID 7131b7133b5ebce905376c59784d1d10503d0fe7 # Parent c386ef4dc431e5065266de2b163260e6f5637b27 Add TreeView into ScrolledWindow to prevent resize of window. #4209 diff -r c386ef4dc431 -r 7131b7133b5e chirp/ui/settingsedit.py --- a/chirp/ui/settingsedit.py Tue Nov 01 18:42:18 2016 -0700 +++ b/chirp/ui/settingsedit.py Fri Nov 11 23:31:35 2016 +0100 @@ -45,12 +45,17 @@ # The selection tree self._store = gtk.TreeStore(gobject.TYPE_STRING, gobject.TYPE_INT) self._view = gtk.TreeView(self._store) - self._view.set_size_request(150, -1) self._view.get_selection().connect("changed", self._view_changed_cb) self._view.append_column( gtk.TreeViewColumn("", gtk.CellRendererText(), text=0)) self._view.show() - paned.pack1(self._view) + scrolled_window = gtk.ScrolledWindow() + scrolled_window.set_policy(gtk.POLICY_AUTOMATIC, gtk.POLICY_AUTOMATIC) + scrolled_window.add_with_viewport(self._view) + scrolled_window.set_size_request(200, -1) + scrolled_window.show() + paned.pack1(scrolled_window) + # The settings notebook self._notebook = gtk.Notebook()

1 0

[chirp_devel] [PATCH] [btech] Add support for 5 Tone-settings. Part of #4051
by Michael Wagner (OE4AMW) 11 Nov '16

11 Nov '16

# HG changeset patch # User Michael Wagner <michael.wagner(a)gmx.at> # Date 1478191827 -3600 # Thu Nov 03 17:50:27 2016 +0100 # Node ID 012141ebcd3a0f70c4f35cd93538c515f7c79fa5 # Parent c386ef4dc431e5065266de2b163260e6f5637b27 [btech] Add support for 5 Tone-settings. Part of #4051 Improved version of the last patch: Restricted 5-Tones only to KT8900R, better checking indices before accessing lists, better grouping on the HMI. diff -r c386ef4dc431 -r 012141ebcd3a chirp/drivers/btech.py --- a/chirp/drivers/btech.py Tue Nov 01 18:42:18 2016 -0700 +++ b/chirp/drivers/btech.py Thu Nov 03 17:50:27 2016 +0100 @@ -155,6 +155,44 @@ u8 unknown1[10]; } names[200]; +#seekto 0x2400; +struct { + u8 period; // one out of LIST_5TONE_STANDARD_PERIODS + u8 group_tone; + u8 repeat_tone; + u8 unused[13]; +} _5tone_std_settings[15]; + +#seekto 0x2500; +struct { + u8 frame1[5]; + u8 frame2[5]; + u8 frame3[5]; + u8 standard; // one out of LIST_5TONE_STANDARDS +} _5tone_codes[15]; + +#seekto 0x25F0; +struct { + u8 _5tone_delay1; // * 10ms + u8 _5tone_delay2; // * 10ms + u8 _5tone_delay3; // * 10ms + u8 _5tone_first_digit_ext_length; + u8 unknown1; + u8 unknown2; + u8 unknown3; + u8 unknown4; + u8 decode_standard; + u8 unknown5:5, + _5tone_decode_call_frame3:1, + _5tone_decode_call_frame2:1, + _5tone_decode_call_frame1:1; + u8 unknown6:5, + _5tone_decode_disp_frame3:1, + _5tone_decode_disp_frame2:1, + _5tone_decode_disp_frame1:1; + u8 decode_reset_time; // * 100 + 100ms +} _5tone_settings; + #seekto 0x3000; struct { u8 freq[8]; @@ -237,6 +275,20 @@ LIST_WIDE = ["Wide", "Narrow"] STEPS = [2.5, 5.0, 6.25, 10.0, 12.5, 25.0] LIST_STEP = [str(x) for x in STEPS] +LIST_5TONE_STANDARDS = ["CCIR1", "CCIR2", "PCCIR", "ZVEI1", "ZVEI2", "ZVEI3", + "PZVEI", "DZVEI", "PDZVEI", "EEA", "EIA", "EURO", + "CCITT", "NATEL", "MODAT", "none"] +LIST_5TONE_STANDARDS_without_none = ["CCIR1", "CCIR2", "PCCIR", "ZVEI1", + "ZVEI2", "ZVEI3", + "PZVEI", "DZVEI", "PDZVEI", "EEA", "EIA", + "EURO", "CCITT", "NATEL", "MODAT"] +LIST_5TONE_STANDARD_PERIODS = ["20", "30", "40", "50", "60", "70", "80", "90", + "100", "110", "120", "130", "140", "150", "160", + "170", "180", "190", "200"] +LIST_5TONE_DIGITS = ["0", "1", "2", "3", "4", "5", "6", "7", "8", "9", "A", + "B", "C", "D", "E", "F"] +LIST_5TONE_DELAY = ["%s ms" % x for x in range(0, 1010, 10)] +LIST_5TONE_RESET = ["%s ms" % x for x in range(100, 8100, 100)] # This is a general serial timeout for all serial read functions. # Practice has show that about 0.7 sec will be enough to cover all radios. @@ -1613,7 +1665,267 @@ fm_presets.append(fmfreq) i = i + 1 + + # 5 Tone Settings + if self.MODEL == "KT8900R": + LOG.debug("This is a " + self.MODEL + ". Adding 5 Tone settings" ) + + stds_5tone = RadioSettingGroup ("stds_5tone", "Standards") + codes_5tone = RadioSettingGroup ("codes_5tone", "Codes") + group_5tone = RadioSettingGroup ("group_5tone", "5 Tone Settings") + group_5tone.append(stds_5tone) + group_5tone.append(codes_5tone) + + top.append(group_5tone) + + def apply_list_value(setting, obj): + options = setting.value.get_options() + obj.set_value ( options.index(str(setting.value)) ) + + _5tone_standards = self._memobj._5tone_std_settings + i = 0 + for standard in _5tone_standards: + std_5tone = RadioSettingGroup ("std_5tone_" + str(i), + LIST_5TONE_STANDARDS[i]) + stds_5tone.append(std_5tone) + if standard.period <= len( LIST_5TONE_STANDARD_PERIODS ): + line = RadioSetting( + "_5tone_std_settings_" + str(i) + "_period", + "Period (ms)", RadioSettingValueList + (LIST_5TONE_STANDARD_PERIODS, + LIST_5TONE_STANDARD_PERIODS[standard.period])) + line.set_apply_callback(apply_list_value, standard.period) + std_5tone.append(line) + else: + LOG.debug("Invalid value for 5tone period! Disabling.") + if standard.group_tone <= len( LIST_5TONE_DIGITS ): + line = RadioSetting( + "_5tone_std_settings_" + str(i) + "_grouptone", + "Group Tone", + RadioSettingValueList(LIST_5TONE_DIGITS, + LIST_5TONE_DIGITS[ + standard.group_tone])) + line.set_apply_callback(apply_list_value, + standard.group_tone) + std_5tone.append(line) + else: + LOG.debug("Invalid value for 5tone digit! Disabling.") + if standard.repeat_tone <= len( LIST_5TONE_DIGITS ): + line = RadioSetting( + "_5tone_std_settings_" + str(i) + "_repttone", + "Repeat Tone", + RadioSettingValueList(LIST_5TONE_DIGITS, + LIST_5TONE_DIGITS[ + standard.repeat_tone])) + line.set_apply_callback(apply_list_value, + standard.repeat_tone) + std_5tone.append(line) + else: + LOG.debug("Invalid value for 5tone digit! Disabling.") + i = i + 1 + + def my_apply_5tonestdlist_value(setting, obj): + if LIST_5TONE_STANDARDS.index(str(setting.value)) == 15: + obj.set_value(0xFF) + else: + obj.set_value( LIST_5TONE_STANDARDS. + index(str(setting.value)) ) + + def apply_5tone_frame(setting, obj): + LOG.debug("Setting 5 Tone: " + str(setting.value) ) + valstring = str(setting.value) + if len(valstring) == 0: + for i in range(0,5): + obj[i] = 255 + else: + validFrame = True + for i in range(0,5): + currentChar = valstring[i].upper() + if currentChar in LIST_5TONE_DIGITS: + obj[i] = LIST_5TONE_DIGITS.index(currentChar) + else: + validFrame = False + LOG.debug("invalid char: " + str(currentChar)) + if not validFrame: + LOG.debug("setting whole frame to FF" ) + for i in range(0,5): + obj[i] = 255 + + def validate_5tone_frame(value): + if (len(str(value)) != 5) and (len(str(value)) != 0) : + msg = ("5 Tone must have 5 digits or 0 digits") + raise InvalidValueError(msg) + for digit in str(value): + if digit.upper() not in LIST_5TONE_DIGITS: + msg = (str(digit) + " is not a valid digit for 5tones") + raise InvalidValueError(msg) + return value + + def frame2string(frame): + frameString = "" + for digit in frame: + if digit != 255: + frameString = frameString + LIST_5TONE_DIGITS[digit] + return frameString + + _5tone_codes = self._memobj._5tone_codes + i = 1 + for code in _5tone_codes: + code_5tone = RadioSettingGroup ("code_5tone_" + str(i), + "5 Tone code " + str(i)) + codes_5tone.append(code_5tone) + if (code.standard == 255 ): + currentVal = 15 + else: + currentVal = code.standard + line = RadioSetting("_5tone_code_" + str(i) + "_std", + " Standard", + RadioSettingValueList(LIST_5TONE_STANDARDS, + LIST_5TONE_STANDARDS[ + currentVal]) ) + line.set_apply_callback(my_apply_5tonestdlist_value, + code.standard) + code_5tone.append(line) + + val = RadioSettingValueString(0, 6, + frame2string(code.frame1), False) + line = RadioSetting("_5tone_code_" + str(i) + "_frame1", + " Frame 1", val) + val.set_validate_callback(validate_5tone_frame) + line.set_apply_callback(apply_5tone_frame, code.frame1) + code_5tone.append(line) + + val = RadioSettingValueString(0, 6, + frame2string(code.frame2), False) + line = RadioSetting("_5tone_code_" + str(i) + "_frame2", + " Frame 2", val) + val.set_validate_callback(validate_5tone_frame) + line.set_apply_callback(apply_5tone_frame, code.frame2) + code_5tone.append(line) + + val = RadioSettingValueString(0, 6, + frame2string(code.frame3), False) + line = RadioSetting("_5tone_code_" + str(i) + "_frame3", + " Frame 3", val) + val.set_validate_callback(validate_5tone_frame) + line.set_apply_callback(apply_5tone_frame, code.frame3) + code_5tone.append(line) + i = i + 1 + + _5_tone_decode1 = RadioSetting( + "_5tone_settings._5tone_decode_call_frame1", + "5 Tone decode call Frame 1", + RadioSettingValueBoolean( + _mem._5tone_settings._5tone_decode_call_frame1)) + group_5tone.append(_5_tone_decode1) + + _5_tone_decode2 = RadioSetting( + "_5tone_settings._5tone_decode_call_frame2", + "5 Tone decode call Frame 2", + RadioSettingValueBoolean( + _mem._5tone_settings._5tone_decode_call_frame2)) + group_5tone.append(_5_tone_decode2) + + _5_tone_decode3 = RadioSetting( + "_5tone_settings._5tone_decode_call_frame3", + "5 Tone decode call Frame 3", + RadioSettingValueBoolean( + _mem._5tone_settings._5tone_decode_call_frame3)) + group_5tone.append(_5_tone_decode3) + + _5_tone_decode_disp1 = RadioSetting( + "_5tone_settings._5tone_decode_disp_frame1", + "5 Tone decode disp Frame 1", + RadioSettingValueBoolean( + _mem._5tone_settings._5tone_decode_disp_frame1)) + group_5tone.append(_5_tone_decode_disp1) + + _5_tone_decode_disp2 = RadioSetting( + "_5tone_settings._5tone_decode_disp_frame2", + "5 Tone decode disp Frame 2", + RadioSettingValueBoolean( + _mem._5tone_settings._5tone_decode_disp_frame2)) + group_5tone.append(_5_tone_decode_disp2) + + _5_tone_decode_disp3 = RadioSetting( + "_5tone_settings._5tone_decode_disp_frame3", + "5 Tone decode disp Frame 3", + RadioSettingValueBoolean( + _mem._5tone_settings._5tone_decode_disp_frame3)) + group_5tone.append(_5_tone_decode_disp3) + + if _mem._5tone_settings.decode_standard != 255 : + line = RadioSetting("_5tone_settings.decode_standard", + "5 Tone-decode Standard", + RadioSettingValueList( + LIST_5TONE_STANDARDS_without_none, + LIST_5TONE_STANDARDS_without_none[ + _mem. + _5tone_settings.decode_standard])) + group_5tone.append(line) + + if _mem._5tone_settings._5tone_delay1 <= len( LIST_5TONE_DELAY ): + list = RadioSettingValueList(LIST_5TONE_DELAY, + LIST_5TONE_DELAY[ + _mem._5tone_settings. + _5tone_delay1]) + line = RadioSetting("_5tone_settings._5tone_delay1", + "5 Tone Delay Frame 1", list) + group_5tone.append(line) + else: + LOG.debug("Invalid value for 5tone delay! Disabling.") + + if _mem._5tone_settings._5tone_delay2 <= len( LIST_5TONE_DELAY ): + list = RadioSettingValueList(LIST_5TONE_DELAY, + LIST_5TONE_DELAY[ + _mem._5tone_settings. + _5tone_delay2]) + line = RadioSetting("_5tone_settings._5tone_delay2", + "5 Tone Delay Frame 2", list) + group_5tone.append(line) + else: + LOG.debug("Invalid value for 5tone delay! Disabling.") + + if _mem._5tone_settings._5tone_delay2 <= len( LIST_5TONE_DELAY ): + list = RadioSettingValueList(LIST_5TONE_DELAY, + LIST_5TONE_DELAY[ + _mem._5tone_settings. + _5tone_delay3]) + line = RadioSetting("_5tone_settings._5tone_delay3", + "5 Tone Delay Frame 3", list ) + group_5tone.append(line) + else: + LOG.debug("Invalid value for 5tone delay! Disabling.") + + if _mem._5tone_settings._5tone_first_digit_ext_length <= len( + LIST_5TONE_DELAY ): + list = RadioSettingValueList( + LIST_5TONE_DELAY, + LIST_5TONE_DELAY[ + _mem._5tone_settings._5tone_first_digit_ext_length]) + line = RadioSetting( + "_5tone_settings._5tone_first_digit_ext_length", + "First digit extend length", list) + group_5tone.append(line) + else: + LOG.debug("Invalid value for 5tone ext length! Disabling.") + + if _mem._5tone_settings.decode_reset_time <= len(LIST_5TONE_RESET): + list = RadioSettingValueList( + LIST_5TONE_RESET, + LIST_5TONE_RESET[ + _mem._5tone_settings.decode_reset_time]) + line = RadioSetting("_5tone_settings.decode_reset_time", + "Decode reset time", list) + group_5tone.append(line) + else: + LOG.debug("Invalid value decode reset time! Disabling.") + else: + LOG.debug("Not adding 5 Tone settings for this model (" + + self.MODEL + "). If your model supports 5 Tone signalling," + + "add more information to #4051") + return top def set_settings(self, settings):

2 1

[chirp_devel] Implementing banks for Alinco DJ-G7EG
by Mathias Weyland 06 Nov '16

06 Nov '16

Hello everyone I am working on adding support for the radio mentioned in the subject because the Alinco programming software is quite crusty and Windows only. I currently have basic support running, which means that I can reliably read from and write to the radio. I am now trying to tackle memory banks. I can read and write the memory bank allocation but I'm struggling with integrating that into chirp. I have studied a few examples of how this is implemented in chirp, in particular for the FT60. Yet I am not quite sure how to approach this and I am looking for general pointers (example code, documentation or hints of any kind are welcome). The radio in question has 50 user defined banks. Those banks do not have names, but the user can set the number of channels contained in each bank dynamically. The number of such channels must add up to 1000. It's kind of an overlay to struct { ...} memory[1000]. The bank assignment is implied by the sizes of the banks defined in another uint16_t[50]. A user could therefore decide to set the first 10 banks to 100 channels each and set the remaining banks to a size of zero. Or have a first bank with 50 channels, then a second bank with 150 channels and 8 more banks with 100 channels as before. A particular channel in a fixed memory position would be transferred from bank 1 to bank 2 if bank 1 is reduced in size and bank 2 is increased accordingly. There are a few more special banks of fixed size that I want to ignore for now. I do understand how to read and write the bank sizes from and to the radio, but what I do not understand is how to modify my current class to integrate the bank feature. As far as I can see, I need to set the "has_bank" feature to true and I need a get_bank_model() method that returns an instance that inherits from chirp_common.BankModel. I am however not entirely sure what methods that custom BankModel has to implement and how all the bits piece together. I'm also concerned that this doesn't quite fit the usual bank paradigm employed in chirp. I'd like to worry with the GUI in a follow-up step. I guess that would be a new tab where the bank sizes can be allocated. Any info on that is welcome too of course. Best regards and thank you Matt

1 0

[chirp_devel] Build test results: Failure
by Build System 03 Nov '16

03 Nov '16

Tested changes: [Tyler Tidman <tyler.tidman(a)draak.ca>] Add 8 new PMR channels to LPD and PMR stock config. Fixes #4107. [Tyler Tidman <tyler.tidman(a)draak.ca>] Minor PEP8 cleanup for some drivers. Fixes #4161. [Michael Wagner <michael.wagner(a)gmx.at>] [btech] Add support for 5Tone-seetings. Contributes to #4051 Added support for all 5-Tone related settings provided by the QYT KT-8900R. Only tested with KT-8900R - reports with other models supported by the btech-driver are highly appreciated. [Tom Hayward <tom(a)tomh.us>] [id880] Fix typo in charset definition. #281 [Tom Hayward <tom(a)tomh.us>] [thf6a] Support full charset (ASCII). Fixes #141 [Tom Hayward <tom(a)tomh.us>] [id880] Support full charset. Fixes #281 [Tom Hayward <tom(a)tomh.us>] [vx5] Support full charset (ASCII). Fixes #292 [Tom Hayward <tom(a)tomh.us>] [id31a] set used bit when creating new memory, clear when deleting. Fixes #269 [Tom Hayward <tom(a)tomh.us>] Support PyGTK < 2.22 in bank edit. Fixes #231 [Tom Hayward <tom(a)tomh.us>] [d710] [v71] [d72] Fix tone list (not all tones are supported). Fixes #212 [Dan Smith <dsmith(a)danplanet.com>] [vx7] Fix setting memory power levels on 220MHz band Fixes #214 [Dan Smith <dsmith(a)danplanet.com>] fips: Pennsylvania FIPS code was wrong. #117 [Marco Filippi <iz3gme.marco(a)gmail.com>] Consider lower bound frequency of each valid_band as valid Fix bug #181 [Tom Hayward <tom(a)tomh.us>] tmd700: allow 8-char names. Fixes #176 [Dan Smith <dsmith(a)danplanet.com>] Fix the "blind deletion" problem, as well as properly direct copy/paste Fixes #172 [David Griffith <dave(a)661.org>] Bug #155 fix: VX-7 1.25m power levels [David Griffith <dave(a)661.org>] New INSTALL and README files Fixes #122 [Tom Hayward <tom(a)tomh.us>] thd72: only use hardware flow on OS X. Fixes #166 [Marco Filippi <iz3gme.marco(a)gmail.com>] [FT817] Tone freq not set correctly Same as #88 for FT857, to avoid code duplication fix code have been moved from ft857 to its ancestor class Fix bug #163 [Tom Hayward <tom(a)tomh.us>] Fix Mac .app so paths with spaces work. Fixes Bug #145 Full log: Started by an SCM change Building in workspace /var/lib/jenkins/jobs/chirp-test/workspace [workspace] $ hg showconfig paths.default [workspace] $ hg pull --rev default [workspace] $ hg update --clean --rev default 12 files updated, 0 files merged, 0 files removed, 0 files unresolved [workspace] $ hg log --rev . --template {node} [workspace] $ hg log --rev . --template {rev} [workspace] $ hg log --rev cc28502a220f297e56fa9d99e7ea74480e1cd15f [workspace] $ hg log --template "<changeset node='{node}' author='{author|xmlescape}' rev='{rev}' date='{date}'><msg>{desc|xmlescape}</msg><added>{file_adds|stringify|xmlescape}</added><deleted>{file_dels|stringify|xmlescape}</deleted><files>{files|stringify|xmlescape}</files><parents>{parents}</parents></changeset>\n" --rev default:0 --follow --prune cc28502a220f297e56fa9d99e7ea74480e1cd15f No emails were triggered. [workspace] $ /bin/sh -xe /tmp/hudson8856357619230356499.sh [workspace] $ /bin/sh -xe /tmp/hudson5791763845228604506.sh + PATH=/usr/bin:/bin:/usr/local/bin ./run_all_tests.sh test_bit_array (tests.unit.test_bitwise.TestBitType) ... ok test_bit_array_fail (tests.unit.test_bitwise.TestBitType) ... ok test_bitfield_u16 (tests.unit.test_bitwise.TestBitfieldTypes) ... ok test_bitfield_u24 (tests.unit.test_bitwise.TestBitfieldTypes) ... ok test_bitfield_u8 (tests.unit.test_bitwise.TestBitfieldTypes) ... ok test_bitfield_ul16 (tests.unit.test_bitwise.TestBitfieldTypes) ... ok test_bitfield_ul24 (tests.unit.test_bitwise.TestBitfieldTypes) ... ok test_bbcd (tests.unit.test_bitwise.TestBitwiseBCDTypes) ... ok test_bbcd_array (tests.unit.test_bitwise.TestBitwiseBCDTypes) ... ok test_lbcd (tests.unit.test_bitwise.TestBitwiseBCDTypes) ... ok test_lbcd_array (tests.unit.test_bitwise.TestBitwiseBCDTypes) ... ok test_int_array (tests.unit.test_bitwise.TestBitwiseBaseIntTypes) ... ok test_type_u16 (tests.unit.test_bitwise.TestBitwiseBaseIntTypes) ... ok test_type_u24 (tests.unit.test_bitwise.TestBitwiseBaseIntTypes) ... ok test_type_u32 (tests.unit.test_bitwise.TestBitwiseBaseIntTypes) ... ok test_type_u8 (tests.unit.test_bitwise.TestBitwiseBaseIntTypes) ... ok test_type_ul16 (tests.unit.test_bitwise.TestBitwiseBaseIntTypes) ... ok test_type_ul24 (tests.unit.test_bitwise.TestBitwiseBaseIntTypes) ... ok test_type_ul32 (tests.unit.test_bitwise.TestBitwiseBaseIntTypes) ... ok test_char (tests.unit.test_bitwise.TestBitwiseCharTypes) ... ok test_string (tests.unit.test_bitwise.TestBitwiseCharTypes) ... ok test_string_invalid_chars (tests.unit.test_bitwise.TestBitwiseCharTypes) ... ok test_string_wrong_length (tests.unit.test_bitwise.TestBitwiseCharTypes) ... ok test_comment_cppstyle (tests.unit.test_bitwise.TestBitwiseComments) ... ok test_comment_inline_cppstyle (tests.unit.test_bitwise.TestBitwiseComments) ... ok test_missing_semicolon (tests.unit.test_bitwise.TestBitwiseErrors) ... ok test_seek (tests.unit.test_bitwise.TestBitwiseSeek) ... ok test_seekto (tests.unit.test_bitwise.TestBitwiseSeek) ... ok test_struct_one_element (tests.unit.test_bitwise.TestBitwiseStructTypes) ... ok test_struct_two_elements (tests.unit.test_bitwise.TestBitwiseStructTypes) ... ok test_struct_writes (tests.unit.test_bitwise.TestBitwiseStructTypes) ... ok split_tone_encode_test_cross_dtcs_tone (tests.unit.test_chirp_common.TestSplitTone) ... ok split_tone_encode_test_cross_none_dtcs (tests.unit.test_chirp_common.TestSplitTone) ... ok split_tone_encode_test_cross_none_tone (tests.unit.test_chirp_common.TestSplitTone) ... ok split_tone_encode_test_cross_tone_dtcs (tests.unit.test_chirp_common.TestSplitTone) ... ok split_tone_encode_test_cross_tone_tone (tests.unit.test_chirp_common.TestSplitTone) ... ok split_tone_encode_test_dtcs (tests.unit.test_chirp_common.TestSplitTone) ... ok split_tone_encode_test_none (tests.unit.test_chirp_common.TestSplitTone) ... ok split_tone_encode_test_tone (tests.unit.test_chirp_common.TestSplitTone) ... ok split_tone_encode_test_tsql (tests.unit.test_chirp_common.TestSplitTone) ... ok test_split_tone_decode_cross_dtcs_dtcs (tests.unit.test_chirp_common.TestSplitTone) ... ok test_split_tone_decode_cross_dtcs_tone (tests.unit.test_chirp_common.TestSplitTone) ... ok test_split_tone_decode_cross_none_dtcs (tests.unit.test_chirp_common.TestSplitTone) ... ok test_split_tone_decode_cross_none_tone (tests.unit.test_chirp_common.TestSplitTone) ... ok test_split_tone_decode_cross_tone_dtcs (tests.unit.test_chirp_common.TestSplitTone) ... ok test_split_tone_decode_cross_tone_tone (tests.unit.test_chirp_common.TestSplitTone) ... ok test_split_tone_decode_dtcs (tests.unit.test_chirp_common.TestSplitTone) ... ok test_split_tone_decode_none (tests.unit.test_chirp_common.TestSplitTone) ... ok test_split_tone_decode_tone (tests.unit.test_chirp_common.TestSplitTone) ... ok test_split_tone_decode_tsql (tests.unit.test_chirp_common.TestSplitTone) ... ok test_fix_rounded_step_250 (tests.unit.test_chirp_common.TestStepFunctions) ... ok test_fix_rounded_step_500 (tests.unit.test_chirp_common.TestStepFunctions) ... ok test_fix_rounded_step_750 (tests.unit.test_chirp_common.TestStepFunctions) ... ok test_is_12_5 (tests.unit.test_chirp_common.TestStepFunctions) ... ok test_is_2_5 (tests.unit.test_chirp_common.TestStepFunctions) ... ok test_is_5_0 (tests.unit.test_chirp_common.TestStepFunctions) ... ok test_is_6_25 (tests.unit.test_chirp_common.TestStepFunctions) ... ok test_is_fractional_step (tests.unit.test_chirp_common.TestStepFunctions) ... ok test_required_step (tests.unit.test_chirp_common.TestStepFunctions) ... ok test_required_step_fail (tests.unit.test_chirp_common.TestStepFunctions) ... ok test_format_freq (tests.unit.test_chirp_common.TestUtilityFunctions) ... ok test_parse_freq_bad (tests.unit.test_chirp_common.TestUtilityFunctions) ... ok test_parse_freq_decimal (tests.unit.test_chirp_common.TestUtilityFunctions) ... ok test_parse_freq_whitespace (tests.unit.test_chirp_common.TestUtilityFunctions) ... ok test_parse_freq_whole (tests.unit.test_chirp_common.TestUtilityFunctions) ... ok test_ensure_has_calls_almost_full (tests.unit.test_import_logic.DstarTests) ... ok test_ensure_has_calls_empty (tests.unit.test_import_logic.DstarTests) ... ok test_ensure_has_calls_partial (tests.unit.test_import_logic.DstarTests) ... ok test_ensure_has_calls_rptcall_full1 (tests.unit.test_import_logic.DstarTests) ... ok test_ensure_has_calls_rptcall_full2 (tests.unit.test_import_logic.DstarTests) ... ok test_ensure_has_calls_urcall_full (tests.unit.test_import_logic.DstarTests) ... ok test_import_bank (tests.unit.test_import_logic.ImportFieldTests) ... ok test_import_dtcs_diffA_dtcs (tests.unit.test_import_logic.ImportFieldTests) ... ok test_import_dtcs_diffB_dtcs (tests.unit.test_import_logic.ImportFieldTests) ... ok test_import_duplex_negative (tests.unit.test_import_logic.ImportFieldTests) ... ok test_import_duplex_too_big_vhf (tests.unit.test_import_logic.ImportFieldTests) ... ok test_import_duplex_uhf (tests.unit.test_import_logic.ImportFieldTests) ... ok test_import_duplex_vhf (tests.unit.test_import_logic.ImportFieldTests) ... ok test_import_mem (tests.unit.test_import_logic.ImportFieldTests) ... ok test_import_mem_with_errors (tests.unit.test_import_logic.ImportFieldTests) ... ok test_import_mem_with_warnings (tests.unit.test_import_logic.ImportFieldTests) ... ok test_import_mode_invalid (tests.unit.test_import_logic.ImportFieldTests) ... ok test_import_mode_valid_am (tests.unit.test_import_logic.ImportFieldTests) ... ok test_import_mode_valid_fm (tests.unit.test_import_logic.ImportFieldTests) ... ok test_import_name (tests.unit.test_import_logic.ImportFieldTests) ... ok test_import_power_closest (tests.unit.test_import_logic.ImportFieldTests) ... ok test_import_power_no_dst (tests.unit.test_import_logic.ImportFieldTests) ... ok test_import_power_no_src (tests.unit.test_import_logic.ImportFieldTests) ... ok test_import_power_same (tests.unit.test_import_logic.ImportFieldTests) ... ok test_import_tone_diffA_tsql (tests.unit.test_import_logic.ImportFieldTests) ... ok test_import_tone_diffB_tsql (tests.unit.test_import_logic.ImportFieldTests) ... ok test_mapping (tests.unit.test_mappingmodel.TestBaseBank) ... ok test_mapping_eq (tests.unit.test_mappingmodel.TestBaseBank) ... ok test_base_class (tests.unit.test_mappingmodel.TestBaseBankModel) ... ok test_get_name (tests.unit.test_mappingmodel.TestBaseBankModel) ... ok test_mapping (tests.unit.test_mappingmodel.TestBaseMapping) ... ok test_mapping_eq (tests.unit.test_mappingmodel.TestBaseMapping) ... ok test_base_class (tests.unit.test_mappingmodel.TestBaseMappingModel) ... ok test_get_name (tests.unit.test_mappingmodel.TestBaseMappingModel) ... ok test_base_class (tests.unit.test_mappingmodel.TestBaseMappingModelIndexInterface) ... ok test_add_memory_to_mapping (tests.unit.test_mappingmodel.TestIcomBankModel) ... ok test_get_mapping_memories (tests.unit.test_mappingmodel.TestIcomBankModel) ... ok test_get_mappings (tests.unit.test_mappingmodel.TestIcomBankModel) ... ok test_get_memory_mappings (tests.unit.test_mappingmodel.TestIcomBankModel) ... ok test_get_num_mappings (tests.unit.test_mappingmodel.TestIcomBankModel) ... ok test_remove_memory_from_mapping (tests.unit.test_mappingmodel.TestIcomBankModel) ... ok test_remove_memory_from_mapping_no_bank (tests.unit.test_mappingmodel.TestIcomBankModel) ... ok test_remove_memory_from_mapping_wrong_bank (tests.unit.test_mappingmodel.TestIcomBankModel) ... ok test_icom_bank (tests.unit.test_mappingmodel.TestIcomBanks) ... ok test_mapping (tests.unit.test_mappingmodel.TestIcomBanks) ... ok test_mapping_eq (tests.unit.test_mappingmodel.TestIcomBanks) ... ok test_add_memory_to_mapping (tests.unit.test_mappingmodel.TestIcomIndexedBankModel) ... ok test_get_index_bounds (tests.unit.test_mappingmodel.TestIcomIndexedBankModel) ... ok test_get_mapping_memories (tests.unit.test_mappingmodel.TestIcomIndexedBankModel) ... ok test_get_mappings (tests.unit.test_mappingmodel.TestIcomIndexedBankModel) ... ok test_get_memory_index (tests.unit.test_mappingmodel.TestIcomIndexedBankModel) ... ok test_get_memory_mappings (tests.unit.test_mappingmodel.TestIcomIndexedBankModel) ... ok test_get_next_mapping_index (tests.unit.test_mappingmodel.TestIcomIndexedBankModel) ... ok test_get_num_mappings (tests.unit.test_mappingmodel.TestIcomIndexedBankModel) ... ok test_remove_memory_from_mapping (tests.unit.test_mappingmodel.TestIcomIndexedBankModel) ... ok test_remove_memory_from_mapping_no_bank (tests.unit.test_mappingmodel.TestIcomIndexedBankModel) ... ok test_remove_memory_from_mapping_wrong_bank (tests.unit.test_mappingmodel.TestIcomIndexedBankModel) ... ok test_set_memory_index (tests.unit.test_mappingmodel.TestIcomIndexedBankModel) ... ok test_set_memory_index_bad_bank (tests.unit.test_mappingmodel.TestIcomIndexedBankModel) ... ok test_set_memory_index_bad_index (tests.unit.test_mappingmodel.TestIcomIndexedBankModel) ... ok test_auto_tone_mode_cross (tests.unit.test_memedit_edits.TestEdits) ... ok test_auto_tone_mode_dtcs (tests.unit.test_memedit_edits.TestEdits) ... ok test_auto_tone_mode_dtcs_pol (tests.unit.test_memedit_edits.TestEdits) ... ok test_auto_tone_mode_dtcs_rx (tests.unit.test_memedit_edits.TestEdits) ... ok test_auto_tone_mode_tone (tests.unit.test_memedit_edits.TestEdits) ... ok test_auto_tone_mode_tsql (tests.unit.test_memedit_edits.TestEdits) ... ok test_init (tests.unit.test_platform.Win32PlatformTest) ... ok test_serial_ports_bad_portnames (tests.unit.test_platform.Win32PlatformTest) ... ok test_serial_ports_sorted (tests.unit.test_platform.Win32PlatformTest) ... ok test_apply_callback (tests.unit.test_settings.TestSettingContainers) ... ok test_radio_setting (tests.unit.test_settings.TestSettingContainers) ... ok test_radio_setting_group (tests.unit.test_settings.TestSettingContainers) ... ok test_radio_setting_multi (tests.unit.test_settings.TestSettingContainers) ... ok test_changed (tests.unit.test_settings.TestSettingValues) ... ok test_radio_setting_value_boolean (tests.unit.test_settings.TestSettingValues) ... ok test_radio_setting_value_float (tests.unit.test_settings.TestSettingValues) ... ok test_radio_setting_value_integer (tests.unit.test_settings.TestSettingValues) ... ok test_radio_setting_value_list (tests.unit.test_settings.TestSettingValues) ... ok test_radio_setting_value_string (tests.unit.test_settings.TestSettingValues) ... ok test_validate_callback (tests.unit.test_settings.TestSettingValues) ... ok test_delete_hole_with_all (tests.unit.test_shiftdialog.ShiftDialogTest) ... ok test_delete_hole_with_all_full (tests.unit.test_shiftdialog.ShiftDialogTest) ... ok test_delete_hole_with_hole (tests.unit.test_shiftdialog.ShiftDialogTest) ... ok test_delete_hole_without_hole (tests.unit.test_shiftdialog.ShiftDialogTest) ... ok test_insert_hole_with_space (tests.unit.test_shiftdialog.ShiftDialogTest) ... ok test_insert_hole_without_space (tests.unit.test_shiftdialog.ShiftDialogTest) ... ok ---------------------------------------------------------------------- Ran 151 tests in 0.053s OK Patch 'tip' is OK Checking for PEP8 regressions... ./chirp/drivers/ft2900.py:781:80: E501 line too long (85 > 79 characters) ./chirp/drivers/ft2900.py:805:80: E501 line too long (85 > 79 characters) ./chirp/drivers/ft2900.py:835:80: E501 line too long (87 > 79 characters) ./chirp/drivers/ft2900.py:842:80: E501 line too long (87 > 79 characters) ./chirp/drivers/ft2900.py:923:80: E501 line too long (87 > 79 characters) ./chirp/drivers/ft2900.py:1106:80: E501 line too long (86 > 79 characters) ./chirp/drivers/ft2900.py:1111:80: E501 line too long (86 > 79 characters) ./chirp/drivers/ft2900.py:1118:80: E501 line too long (86 > 79 characters) ./chirp/drivers/ft2900.py:1123:80: E501 line too long (88 > 79 characters) ./chirp/drivers/ft2900.py:1169:80: E501 line too long (88 > 79 characters) ./chirp/drivers/ft2900.py:1174:80: E501 line too long (90 > 79 characters) ./chirp/drivers/ft2900.py:1238:1: E265 block comment should start with '# ' ./chirp/drivers/ft60.py:490:80: E501 line too long (85 > 79 characters) ./chirp/drivers/ft60.py:495:80: E501 line too long (87 > 79 characters) ./chirp/drivers/ft60.py:500:80: E501 line too long (87 > 79 characters) ./chirp/drivers/ft60.py:505:80: E501 line too long (87 > 79 characters) ./chirp/drivers/ft60.py:510:80: E501 line too long (87 > 79 characters) ./chirp/drivers/ft60.py:538:80: E501 line too long (87 > 79 characters) ./chirp/drivers/ft60.py:556:80: E501 line too long (87 > 79 characters) ./chirp/drivers/ft60.py:567:80: E501 line too long (86 > 79 characters) ./chirp/drivers/ft60.py:584:80: E501 line too long (87 > 79 characters) ./chirp/drivers/ft60.py:589:80: E501 line too long (86 > 79 characters) ./chirp/drivers/ft60.py:594:80: E501 line too long (86 > 79 characters) ./chirp/drivers/ft60.py:599:80: E501 line too long (88 > 79 characters) ./chirp/drivers/ft60.py:605:80: E501 line too long (86 > 79 characters) ./chirp/drivers/ft60.py:610:80: E501 line too long (87 > 79 characters) ./chirp/drivers/ft60.py:621:80: E501 line too long (85 > 79 characters) ./chirp/drivers/ft60.py:632:80: E501 line too long (87 > 79 characters) ./chirp/drivers/ft60.py:637:80: E501 line too long (83 > 79 characters) ./chirp/drivers/ft60.py:642:80: E501 line too long (86 > 79 characters) ./chirp/drivers/ft60.py:647:80: E501 line too long (87 > 79 characters) ./chirp/drivers/ft60.py:652:80: E501 line too long (87 > 79 characters) ./chirp/drivers/ft60.py:657:80: E501 line too long (86 > 79 characters) ./chirp/drivers/ft817.py:1010:80: E501 line too long (85 > 79 characters) ./chirp/drivers/ft817.py:1087:80: E501 line too long (94 > 79 characters) ./chirp/drivers/kguv8d.py:692:80: E501 line too long (83 > 79 characters) ./chirp/drivers/kguv8d.py:721:80: E501 line too long (85 > 79 characters) ./chirp/drivers/kguv8d.py:725:80: E501 line too long (80 > 79 characters) ./chirp/drivers/kguv8d.py:740:80: E501 line too long (83 > 79 characters) ./chirp/drivers/kguv8d.py:754:80: E501 line too long (82 > 79 characters) ./chirp/drivers/kguv8d.py:758:80: E501 line too long (80 > 79 characters) ./chirp/drivers/kguv8d.py:768:80: E501 line too long (84 > 79 characters) ./chirp/drivers/kguv8d.py:772:80: E501 line too long (85 > 79 characters) ./chirp/drivers/kguv8d.py:783:80: E501 line too long (80 > 79 characters) ./chirp/drivers/kguv8d.py:794:80: E501 line too long (83 > 79 characters) ./chirp/drivers/kguv8d.py:811:80: E501 line too long (85 > 79 characters) ./chirp/drivers/leixen.py:956:80: E501 line too long (87 > 79 characters) ./chirp/drivers/thd72.py:205:80: E501 line too long (89 > 79 characters) ./chirp/drivers/thd72.py:206:80: E501 line too long (101 > 79 characters) ./chirp/settings.py:256:80: E501 line too long (81 > 79 characters) ./chirp/ui/mainapp.py:1379:80: E501 line too long (80 > 79 characters) real 0m7.569s user 0m7.476s sys 0m0.016s ================================================ Tests FAILED: driver tests Build step 'Execute shell' marked build as failure Email was triggered for: Failure Sending email for trigger: Failure

3 6

[chirp_devel] [PATCH] [uv5r] Memorize extra-settings before erasing memory. Fix for UV-5R of issue #4121
by Michael Wagner (OE4AMW) 03 Nov '16

03 Nov '16

# HG changeset patch # User Michael Wagner <michael.wagner(a)gmx.at> # Date 1478169599 -3600 # Thu Nov 03 11:39:59 2016 +0100 # Node ID 8dc525acb583b9dbfbd88eb10a83e52816750edd # Parent c386ef4dc431e5065266de2b163260e6f5637b27 [uv5r] Memorize extra-settings before erasing memory. Fix for UV-5R of issue #4121 Try two, with consistent naming of variables. diff -r c386ef4dc431 -r 8dc525acb583 chirp/drivers/uv5r.py --- a/chirp/drivers/uv5r.py Tue Nov 01 18:42:18 2016 -0700 +++ b/chirp/drivers/uv5r.py Thu Nov 03 11:39:59 2016 +0100 @@ -860,6 +860,20 @@ _nam.set_raw("\xff" * 16) return + was_empty = False + # same method as used in get_memory to find + # out whether a raw memory is empty + if _mem.get_raw()[0] == "\xff": + was_empty = True + LOG.debug("UV5R: this mem was empty") + else: + # memorize old extra-values before erasing the whole memory + # used to solve issue 4121 + LOG.debug("mem was not empty, memorize extra-settings") + prev_bcl = _mem.bcl.get_value() + prev_scode = _mem.scode.get_value() + prev_pttid = _mem.pttid.get_value() + _mem.set_raw("\x00" * 16) _mem.rxfreq = mem.freq / 10 @@ -929,6 +943,12 @@ else: _mem.lowpower = 0 + if not was_empty: + #restoring old extra-settings (issue 4121 + _mem.bcl.set_value(prev_bcl) + _mem.scode.set_value(prev_scode) + _mem.pttid.set_value(prev_pttid) + for setting in mem.extra: setattr(_mem, setting.get_name(), setting.value)

1 0

[chirp_devel] Patch for UV5R driver to fix communication on Ubuntu 16.04 with pl2303-based cables (fixes #4165)
by Adam Novak 03 Nov '16

03 Nov '16

Baofeng shipped me an ostensibly pl2303-based programming cable with my UV-82, which I successfully used to program my radio with CHIRP on Ubuntu about two years ago. Today, I am now on Ubuntu 16.04, and I couldn't get CHIRP to talk to the same radio over the same cable. It turns out that newer Ubntu versions ship a driver for the pl2303 that holds DTR low on the serial side (at least until the port is opened), and this puts the radio into transmit mode. The radio needs a little time to come out of it before it can talk to CHIRP, but CHIRP forges ahead with its commands as soon as it opens the port. It's not crazy behavior on the part of the Ubuntu driver; DTR high means the computer is ready to talk to the device, and if the port is closed the computer is probably not ready to talk to the device. So I think it's appropriate to patch CHIRP rather than try and change the behavior on the LInux side. This patch explicitly sets DTR high, and waits a bit, before trying to talk to the radio. I'm patching the UV5R driver, which gets used for the UV-82. This fixes issue #4165, which I reported so I could send in this patch. I have successfully used this patch to program my radio with CHIRP. If there are any other radios that misbehave when DTR is low, and any other cables in common use based on this chip, it may make sense to patch those radio drivers as well.

2 2

[chirp_devel] [PATCH] [KG-UV8D] Add TX Inhibited Channel Support
by Jim Unroe 03 Nov '16

03 Nov '16

# HG changeset patch # User Jim Unroe <rock.unroe(a)gmail.com> # Date 1478135417 14400 # Node ID 46c8ed25793cb224da74753153ebca9afad54156 # Parent c386ef4dc431e5065266de2b163260e6f5637b27 [KG-UV8D] Add TX Inhibited Channel Support The Wouxun KG-UV8D supports the ability to program channels with TX disabled. This patch adds support for this feature. Related to #4175 diff -r c386ef4dc431 -r 46c8ed25793c chirp/drivers/kguv8d.py --- a/chirp/drivers/kguv8d.py Tue Nov 01 18:42:18 2016 -0700 +++ b/chirp/drivers/kguv8d.py Wed Nov 02 21:10:17 2016 -0400 @@ -475,7 +475,7 @@ rf.valid_modes = ["FM", "NFM"] rf.valid_power_levels = self.POWER_LEVELS rf.valid_name_length = 8 - rf.valid_duplexes = ["", "+", "-", "split"] + rf.valid_duplexes = ["", "-", "+", "split", "off"] rf.valid_bands = [(134000000, 175000000), # supports 2m (400000000, 520000000)] # supports 70cm rf.valid_characters = chirp_common.CHARSET_ASCII @@ -554,7 +554,11 @@ mem.freq = int(_mem.rxfreq) * 10 - if int(_mem.rxfreq) == int(_mem.txfreq): + if _mem.txfreq == 0xFFFFFFFF: + # TX freq not set + mem.duplex = "off" + mem.offset = 0 + elif int(_mem.rxfreq) == int(_mem.txfreq): mem.duplex = "" mem.offset = 0 elif abs(int(_mem.rxfreq) * 10 - int(_mem.txfreq) * 10) > 70000000: @@ -629,7 +633,9 @@ return _mem.rxfreq = int(mem.freq / 10) - if mem.duplex == "split": + if mem.duplex == "off": + _mem.txfreq = 0xFFFFFFFF + elif mem.duplex == "split": _mem.txfreq = int(mem.offset / 10) elif mem.duplex == "off": for i in range(0, 4):

1 0

[chirp_devel] [Correction] Minor PEP8 cleanup for some drivers. Fixes #4161.
by Tyler Tidman 02 Nov '16

02 Nov '16

Jim Unroe caught an oops. autopep8 does most of the work but some of the lines were still longer than 80 chars and this has now been fixed. Please disregard my first patch for #4161. All regular "run_tests" tests still pass. 73, Tyler VA3DGN

2 1

[chirp_devel] [PATCH] [uv5r] Memorize extra-settings before erasing memory. Fix for UV-5R of issue #4121
by Michael Wagner (OE4AMW) 02 Nov '16

02 Nov '16

# HG changeset patch # User Michael Wagner <michael.wagner(a)gmx.at> # Date 1477250713 -7200 # Sun Oct 23 21:25:13 2016 +0200 # Node ID 08ef1c3de3998c15997513a5c199f007857c3f0c # Parent cc28502a220f297e56fa9d99e7ea74480e1cd15f [uv5r] Memorize extra-settings before erasing memory. Fix for UV-5R of issue #4121 UV-5R-driver deletes the whole memory before setting the values from UI. As mem.extra is not supplied when memory is edited from the table, this resets the Extra-Settings. This patch memorizes the values before the deletion, and restores them afterwards. diff -r cc28502a220f -r 08ef1c3de399 chirp/drivers/uv5r.py --- a/chirp/drivers/uv5r.py Sun Oct 16 16:55:56 2016 -0700 +++ b/chirp/drivers/uv5r.py Sun Oct 23 21:25:13 2016 +0200 @@ -860,6 +860,17 @@ _nam.set_raw("\xff" * 16) return + wasEmpty = False + if _mem.get_raw()[0] == "\xff": + wasEmpty = True + LOG.debug("UV5R: this mem was empty") + else: + #memorize old extra-values before erasing the whole memory - used to solve issue 4121 + LOG.debug("mem was not empty, memorize extra-settings") + prev_bcl = _mem.bcl.get_value() + prev_scode = _mem.scode.get_value() + prev_pttid = _mem.pttid.get_value() + _mem.set_raw("\x00" * 16) _mem.rxfreq = mem.freq / 10 @@ -929,6 +940,12 @@ else: _mem.lowpower = 0 + if not wasEmpty: + #restoring old extra-settings (issue 4121 + _mem.bcl.set_value(prev_bcl) + _mem.scode.set_value(prev_scode) + _mem.pttid.set_value(prev_pttid) + for setting in mem.extra: setattr(_mem, setting.get_name(), setting.value)

2 1